-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text Input - Hover - Define state styling (Success/Warning/Error status) #1881
Comments
@natalia-fitzgerald 👍 to adding a hover state for fields in error status, as shown above, and (as we discussed) to do likewise for checkboxes. (If this isn't added, a field in error status will show our default blue hover state.) @anselmbradford for awareness. (ETA: Natalia will also add hover states for success and warning, see comment below) |
Ok, to confirm here are the colors for the hover states: I don't have a use case for hover on success or warning in the work I'm doing but since the code currently defines these hover states as Pacific I recommend updating Success and Warning for the sake of consistent logic. Success
Warning
Error
|
I have made these changes to the Figma DS library file on a branch here. @natalia-fitzgerald @sonnakim and @jenn-franklin If you like I can merge the branch and publish the changes to the file after a review. Just let me know. |
@itsmedavep |
I merged the changes and republished. TY everyone! |
I think this is completed @shindigira? Just still waiting on review? |
Yes, need a final approval from @natalia-fitzgerald |
As part of the React component library (and lending app) we are currently looking to nail down the state styling for text input (Error status).
In the Design System we currently define the states as follows:
This is not visualized on the documentation page but is in the code. The hover state is Pacific while the other states are red. I am not sure whether this is intentional or a default style that was never customized for the error status.
![Screenshot 2024-01-17 at 2 09 26 PM](https://private-user-images.githubusercontent.com/77348967/297516126-b308848a-ab18-4cfe-abcd-6461d2899049.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2ODM3NzEsIm5iZiI6MTczOTY4MzQ3MSwicGF0aCI6Ii83NzM0ODk2Ny8yOTc1MTYxMjYtYjMwODg0OGEtYWIxOC00Y2ZlLWFiY2QtNjQ2MWQyODk5MDQ5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDA1MjQzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ2NDgxODVlNjUzMjc2OWE3ZjBmYjdkYjQzYWY5YzE1NzMyMjFhZGNlMjVjY2Y1NWJkMWVkNTg0NTFmYzM4MzcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.zxJPU3XU-tfLGo8hKBqAlicFIQJqcfF_BP8Jhi5Oo98)
If we apply the same visual logic that we do for the "destructive link" we could go with a dark red on hover.
That would look like this. What do you think?
![Screenshot 2024-01-17 at 3 15 54 PM](https://private-user-images.githubusercontent.com/77348967/297516474-6996f109-6a2c-47e3-8f9c-3f3092e187ef.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2ODM3NzEsIm5iZiI6MTczOTY4MzQ3MSwicGF0aCI6Ii83NzM0ODk2Ny8yOTc1MTY0NzQtNjk5NmYxMDktNmEyYy00N2UzLThmOWMtM2YzMDkyZTE4N2VmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDA1MjQzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdiZjE0OTExZDg1NTQ3M2Y2OGYzN2UyYmZhNDRkNDhhYTU4MTg3YWM0ZjZjNDQ1MTJmMTQ2NTU0NmZlNDVjMGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.K_b_-LTkprj0_MVxBLDdGNL61Nh44iBH-3m4FTHFnI8)
I cross-referenced USWDS and they don't appear to have a separate hover style for their text inputs.
Default
![Screenshot 2024-01-17 at 4 11 50 PM](https://private-user-images.githubusercontent.com/77348967/297519299-9f9cf1ef-f1c0-4381-8370-596a956ad74f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2ODM3NzEsIm5iZiI6MTczOTY4MzQ3MSwicGF0aCI6Ii83NzM0ODk2Ny8yOTc1MTkyOTktOWY5Y2YxZWYtZjFjMC00MzgxLTgzNzAtNTk2YTk1NmFkNzRmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDA1MjQzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc2ODMzNThjOGQ4ZDczNzAyZmQwY2M2MzM2MGVkOWEyNmMxMjdmMWU2NjZmZDI4ZDk4NDI3NThhNTU5YmRkZGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.phhKBvWXlgL7XO-bO-FOC2KoG_QCwbe455DWVS2nUV0)
Hover (No change)
![Screenshot 2024-01-17 at 4 11 50 PM](https://private-user-images.githubusercontent.com/77348967/297519299-9f9cf1ef-f1c0-4381-8370-596a956ad74f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2ODM3NzEsIm5iZiI6MTczOTY4MzQ3MSwicGF0aCI6Ii83NzM0ODk2Ny8yOTc1MTkyOTktOWY5Y2YxZWYtZjFjMC00MzgxLTgzNzAtNTk2YTk1NmFkNzRmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDA1MjQzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc2ODMzNThjOGQ4ZDczNzAyZmQwY2M2MzM2MGVkOWEyNmMxMjdmMWU2NjZmZDI4ZDk4NDI3NThhNTU5YmRkZGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.phhKBvWXlgL7XO-bO-FOC2KoG_QCwbe455DWVS2nUV0)
The only change here is a cursor change.
Focus
![Screenshot 2024-01-17 at 4 11 45 PM](https://private-user-images.githubusercontent.com/77348967/297519452-59032389-03c0-4637-8b6b-054a1998f6f1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2ODM3NzEsIm5iZiI6MTczOTY4MzQ3MSwicGF0aCI6Ii83NzM0ODk2Ny8yOTc1MTk0NTItNTkwMzIzODktMDNjMC00NjM3LThiNmItMDU0YTE5OThmNmYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDA1MjQzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI1MDg4MzdhMjRkOTkzNGM1MmE2NGU2NGUyMjJmZjIyYzU2NDU0MmU5OGZlYjQ3ZmFiMjdlZmE3NTNlZTM2ZjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.2FTdId1Ezo3B_IskaAHVRd2jjFLNZUm03E9HAsR-N-M)
@sonnakim for guidance
The text was updated successfully, but these errors were encountered: