Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine the config and the filter file #231

Open
ryaneberly opened this issue Jan 7, 2017 · 3 comments
Open

Combine the config and the filter file #231

ryaneberly opened this issue Jan 7, 2017 · 3 comments
Assignees
@ryaneberly
Milestone
1.6.0

Comments

@ryaneberly
Copy link
Contributor

The config file and the filter file seem to fill similar roles, deprecate the filter file
@ryaneberly ryaneberly self-assigned this Jan 7, 2017
@ryaneberly
Copy link
Contributor Author

retract. filterfile allows more specific targets like functions, than the config does.

@timbeadle
Copy link

Could the config file not have a new property called filter?

@KamasamaK
Copy link
Collaborator

KamasamaK commented Jan 5, 2018 •
edited
Loading

Is there a good reason that we couldn't add additional properties to excludes? It already takes a code in the same way as cflintexclude.json, so also being able to provide a file path or function name should be doable, I think. As for ignoring files/folders entirely, we have the proposed .cflintignore for that.

Related: #528 and #531

@KamasamaK KamasamaK reopened this Jan 5, 2018
@ryaneberly ryaneberly added this to the 1.5.0 milestone Jun 1, 2018
@ryaneberly ryaneberly modified the milestones: 1.5.0, 1.6.0 Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryaneberly ryaneberly

Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
3 participants
@timbeadle @ryaneberly @KamasamaK