Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-4159: Changed to info log level on promise repaired for groups promise type #89

Closed
wants to merge 1 commit into from
Closed

CFE-4159: Changed to info log level on promise repaired for groups promise type #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion promise-types/groups/groups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def evaluate_promise(self, promiser, attributes, meta):
return Result.NOT_KEPT

if repairs > 0:
self.log_verbose("Promise '%s' repaired" % promiser)
self.log_info("Promise '%s' repaired" % promiser)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right. The outcome of the promise fits well in verbose log. What we'd like in the info log is real (human readable) information about what was changed.

I see there is already 1 good log message for this above (Deleted group '%s').

So I'd say keep this one as is, but introduce other info log messages further up / where the changes are actually made.

Some ideas;

Added 'larsewi' to 'developers' group
Removed 'larsewi' from 'developers' group
Set members of 'developers' group to be: larsewi, craigcomstock

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, as we were just discussing this in regards to the ini module. 👍

return Result.REPAIRED

self.log_verbose("Promise '%s' kept" % promiser)
Expand Down