Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE-3812: cfbs init now prompts user whether to use default masterfiles #110

Merged
merged 3 commits into from
Apr 28, 2022
Merged

CFE-3812: cfbs init now prompts user whether to use default masterfiles #110

merged 3 commits into from
Apr 28, 2022

Conversation

larsewi
Copy link
Contributor

@larsewi larsewi commented Apr 27, 2022 •
edited
Loading

The cfbs init command now prompts users whether or not they want to use
the default masterfiles policy framework. If the user says no, they're
prompted with which masterfiles they want to add, allowing them to skip
if empty.

Ticket: CFE-3812
Changelog: Title
Signed-off-by: Lars Erik Wik [email protected]

@larsewi larsewi marked this pull request as ready for review April 27, 2022 15:23
@larsewi larsewi requested review from vpodzime and olehermanse April 27, 2022 15:23
olehermanse
olehermanse reviewed Apr 27, 2022
View reviewed changes
@larsewi larsewi changed the title CFE-3812: cfbs init now promts user whether to use default masterfiles CFE-3812: cfbs init now prompts user whether to use default masterfiles Apr 27, 2022
vpodzime
vpodzime reviewed Apr 28, 2022
View reviewed changes
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cfbs --non-interactive init now adds MPF? Is that what we want?

larsewi
larsewi commented Apr 28, 2022
View reviewed changes
@larsewi
Copy link
Contributor Author

larsewi commented Apr 28, 2022

So cfbs --non-interactive init now adds MPF? Is that what we want?

The option --non-interactive should probably perform the default behaviour? In this case the question would be; should cfbs init add MPF by default? 🤔 What do you think @vpodzime @olehermanse?

@olehermanse
Copy link
Member

So cfbs --non-interactive init now adds MPF? Is that what we want?

Yes

@olehermanse
Copy link
Member

So cfbs --non-interactive init now adds MPF? Is that what we want?

The option --non-interactive should probably perform the default behaviour? In this case the question would be; should cfbs init add MPF by default? 🤔

Yes and yes

larsewi and others added 2 commits April 28, 2022 14:04
@larsewi @olehermanse
cfbs init now prompts user whether to use default masterfiles
8e3ccb4 
The cfbs init command now prompts users whether or not they want to use
the default masterfiles policy framework. If the user says no, they're
prompted with which masterfiles they want to add, allowing them to skip
if empty.

Ticket: CFE-3812
Changelog: Title
Signed-off-by: Lars Erik Wik <[email protected]>
Co-authored-by: Ole Herman Schumacher Elgesem <[email protected]>
@larsewi
Update shell tests after change to cfbs init
8e329e8 
Ticket: CFE-3812
Changelog: None
Signed-off-by: Lars Erik Wik <[email protected]>
olehermanse
olehermanse requested changes Apr 28, 2022
View reviewed changes
@larsewi @olehermanse
Update cfbs/commands.py
3f519b8 
Co-authored-by: Ole Herman Schumacher Elgesem <[email protected]>
@olehermanse olehermanse merged commit d4abb80 into cfengine:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpodzime vpodzime vpodzime left review comments

@olehermanse olehermanse olehermanse approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larsewi @olehermanse @vpodzime