Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency on the 'requests' Python package #109

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

vpodzime
Copy link
Contributor

The 'requests' package is not part of the standard Python library
and build set. We don't use the package extensively so to avoid
requiring dependencies, we can just use 'urllib' which is part of
the standard library and build set.

Ticket: ENT-8439
Changelog: Removed dependency on the 'requests' package

@vpodzime vpodzime requested a review from olehermanse April 25, 2022 09:43
The 'requests' package is not part of the standard Python library
and build set. We don't use the package extensively so to avoid
requiring dependencies, we can just use 'urllib' which is part of
the standard library and build set.

Ticket: ENT-8439
Changelog: Removed dependency on the 'requests' package
On some platforms 'import urllib' doesn't make 'urllib.request'
available.

Ticket: ENT-8439
Changelog: None
@vpodzime vpodzime force-pushed the master-no_requests branch from 5c0f720 to 269c181 Compare April 25, 2022 09:47
@vpodzime vpodzime requested a review from larsewi April 25, 2022 11:03
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@olehermanse olehermanse merged commit 5d910cc into cfengine:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants