CFE-3813: Track changes done by cfbs commands in Git #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There shouldn't be multiple instances of the class manipulating with the same file. Plus we can use the single instance to store runtime configration options (no_interactive, dry_run?,...). Ticket: CFE-3813 Changelog: None
Instead of passing it to some of them and not having it implemented for others. Also remove the index_path argument from places where it is not used. Ticket: CFE-3813 Changelog: None
It's part of the configuration for the particular 'cfbs' run. And we can potentially make it part of the cfbs.json config in the future. Ticket: CFE-3813 Changelog: None
Instead of always checking the non_interactive flag, checking if the user entered valid input, setting the default on empty input,... Ticket: CFE-3813 Changelog: None
Instead of just writing the defaults to the config and asking them to edit it. Ticket: CFE-3813 Changelog: None
Some helper code to deal with the tricky bits of initializing git and making commits. Ticket: CFE-3813 Changelog: None
vpodzime
force-pushed
the
master-git
branch
5 times, most recently
from
13f5b28 to
0de77da
Compare
It's always a good idea to track changes in policy and related files. So unless user explicitly disagrees, 'cfbs' commands now record changes in a Git repository. Also, 'clean' and 'update' commands were modified to have different return/exit codes when they make some and no changes. Ticket: CFE-3813 Changelog: cfbs commands now track changes they make in a Git repository
olehermanse
approved these changes
Mar 25, 2022
Comment on lines
233
to
240
| user_name = git_get_config("user.name") | ||
| user_email = git_get_config("user.email") | ||
| user_name = prompt_user("Please enter user name to use for git commits", | ||
| default=user_name or "cfbs") | ||
|
|
||
| node_name = os.uname().nodename | ||
| user_email = prompt_user("Please enter user email to use for git commits", | ||
| default=user_email or ("cfbs@%s" % node_name)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.