Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend asciidoc GitHub Action workflow to manage publication of docs #335

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Extend asciidoc GitHub Action workflow to manage publication of docs #335

merged 1 commit into from
Sep 6, 2021

Conversation

lesserwhirls
Copy link
Contributor

In addition to building the conventions and conformance docs, extend the GitHub Action workflow to manage the publication of the docs to the gh-pages branch based off the workflow of the travis.yml config.

Demonstration

Pull request against master

PR: https://github.com/lesserwhirls/cf-conventions/pull/9
Action: Conventions and conformance documentation built, preview artifact uploaded
No changes to gh-pages branch.

Pull request merged into master

Action: Conventions and conformance documentation built, documentation updated in root directory of gh-pages branch.
After Action: gh-pages branch.

GitHub release published

Action: Conventions and conformance documentation built, documentation updated in release version directory of gh-pages branch
After Action: gh-pages branch.

Closes #297

In addition to building the conventions and conformance docs, extend the
GitHub Action workflow to manage the publication of the docs to the
gh-pages branch based off the workflow of the travis.yml config.
@lesserwhirls
Copy link
Contributor Author

I just realized forgot to remove the workflow_dispatch event trigger (thus the update), but now the PR should be good for review.

Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new workflow looks sound to me and it works based on the Actions runs and logs. Great stuff.

@erget
Copy link
Member

erget commented Sep 6, 2021

Thanks @lesserwhirls and @sadielbartholomew , merging!

@erget erget merged commit 5060d16 into cf-convention:master Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Travis build into GitHub Actions
3 participants