Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use helm-tool for generating helm docs #182

Merged

Conversation

ThatsMrTalbot
Copy link
Contributor

Part of moving everything to a common format/tool for helm docs.

Preview of the changes can be seen here:
https://github.com/ThatsMrTalbot/cert-manager-csi-driver/blob/feat/helm-tool-for-docs/deploy/charts/csi-driver/README.md

Depends on this PR being merged first #181

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 18, 2024
@ThatsMrTalbot ThatsMrTalbot force-pushed the feat/helm-tool-for-docs branch from 0317255 to cb40561 Compare January 21, 2024 14:40
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2024
@ThatsMrTalbot ThatsMrTalbot force-pushed the feat/helm-tool-for-docs branch from cb40561 to 08d2c97 Compare January 22, 2024 10:15
Copy link
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@jetstack-bot jetstack-bot merged commit bbecb0c into cert-manager:main Jan 22, 2024
5 checks passed
inteon pushed a commit to inteon/csi-driver that referenced this pull request Dec 11, 2024
[CI] Self-upgrade merging self-upgrade-main into main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants