Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon shrinks with long content #194

Closed
3 tasks done
andij opened this issue Feb 2, 2022 · 2 comments
Closed
3 tasks done

Icon shrinks with long content #194

andij opened this issue Feb 2, 2022 · 2 comments
Labels
Severity: Medium Limited impact on user interaction, should be resolved but not required for immediate focus Status: Completed Nothing further to be done with this issue. Awaiting to be closed Type: Bug Something isn't working

Comments

@andij
Copy link
Contributor

andij commented Feb 2, 2022

Describe the bug

The icon alongside the details and validation will shrink when there's longer content than the width of the viewport.

  • details
  • inputter-details
  • inputter-validation

To Reproduce

Steps to reproduce the behavior:

  1. Visit Storybook
  2. Go to the muon-detail and muon-inputter component
  3. Make the viewport narrow
  4. Increase the length of the content in the heading and message
  5. Observe the icons get smaller

Expected behavior

The icons should retain their defined size

Screenshots

image

image

image

Desktop (please complete the following information):

  • OS: All
  • Browser: All
  • Version: All

Smartphone (please complete the following information):

  • Device: All
  • OS: All
  • Browser: All
  • Version: All

Additional context

Setting flex-shrink: 0; on the <detail-icon> will help.

It will be necessary to pay attention to the vertical alignment, as it's currently inconsistent. This may require a separate ticket.

@andij andij added Type: Bug Something isn't working Severity: Medium Limited impact on user interaction, should be resolved but not required for immediate focus labels Feb 2, 2022
@andij andij mentioned this issue Feb 2, 2022
48 tasks
@andij
Copy link
Contributor Author

andij commented Feb 2, 2022

NOTE: Applying align-self: baseline; fixes the inconsistency with the vertical alignment of the icon. However, it is a fragile solution as it relies on the height of the icon being the same height as the line-height.

@andij andij added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Feb 2, 2022
@jholt1
Copy link
Contributor

jholt1 commented Feb 2, 2022

Okay let's go with baseline and see what happens with further usage

@andij andij added Status: Completed Nothing further to be done with this issue. Awaiting to be closed and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Feb 2, 2022
@PtitBen PtitBen assigned andij and unassigned andij Feb 3, 2022
@PtitBen PtitBen closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Severity: Medium Limited impact on user interaction, should be resolved but not required for immediate focus Status: Completed Nothing further to be done with this issue. Awaiting to be closed Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants