Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocklists download/update doesn't work #952

Open
RedSteel-1 opened this issue Jul 22, 2023 · 16 comments
Open

Blocklists download/update doesn't work #952

RedSteel-1 opened this issue Jul 22, 2023 · 16 comments
Assignees
Labels
bug Something isn't working P0 Priority: 0 (urgent and important)

Comments

@RedSteel-1
Copy link

RedSteel-1 commented Jul 22, 2023

The process of downloading/updating blockilists is constantly stuck, the "downloading" circle animation goes on for 1 hour now without any changes.
On 2 different phones.

Could this be fixed?

Is there something wrong going on with the blocklist sources?


Update 30 minutes later:

  • The phone where the update was running got an on-screen message "something went wrong, try again later" and the update stopped.
  • On the phone where the download was running, the download just stopped.

Something is certainly wrong.

@RedSteel-1 RedSteel-1 changed the title Blocklists download/update doesn't work / always stuck Blocklists download/update doesn't work Jul 22, 2023
@ignoramous
Copy link
Collaborator

ignoramous commented Jul 28, 2023

Are you from China / Turkmenistan? Some countries block rethinkdns servers, so downloads won't succeed: #293

If not, consider toggling Use in-app downloader (from DNS -> Configure -> Advanced) to see if the blocklist download then works?

If not, and if you know how, can you share the output from adb logcat as you attempt a new download (which fails)?

@RedSteel-1
Copy link
Author

RedSteel-1 commented Aug 5, 2023

Are you from China / Turkmenistan?

No I'm not from any of the countries where the servers could b blocked

If not, consider toggling Use in-app downloader (from DNS -> Configure -> Advanced) to see if the blocklist download then works?

Trying right now, will post the result whether it worked or not.
It's running 10 minutes with "download in progress" so far


In any case, this is very strange, the download has been working before.

I have Rethink running in always-on & lockdown modes, Download Manager is not blocked in the firewall, so all should be working..

@RedSteel-1
Copy link
Author

If not, consider toggling Use in-app downloader (from DNS -> Configure -> Advanced) to see if the blocklist download then works?

Took a while, but the download was successful, thanks for the workaround.

Wondering, why it doesn't work with Download Manager? It is not blocked and has internet access

@ignoramous
Copy link
Collaborator

ignoramous commented Aug 5, 2023

Wondering, why it doesn't work with Download Manager? It is not blocked and has internet access

Do you have the setting Use in-app downloader turned ON or OFF? If it is turned OFF, then Android's built-in Download Manager is what's working.

@RedSteel-1
Copy link
Author

Now I have it ON now, after your advice, and it worked.

So, wondering why it doesn't work with Download Manager while it is not blocked and has internet access, it worked before.

@ignoramous
Copy link
Collaborator

So, wondering why it doesn't work with Download Manager while it is not blocked and has internet access, it worked before.

My guesses are:

  1. Your device is on a custom ROM that has a broken Download Manager.
  2. Your device is on latest and greatest Android version we haven't yet tested Rethink on.
  3. There's a bug in the way Rethink uses the Download Manager (unlikely).
  4. Rethink downloads are blocked either by the ISP or the router or something.

@RedSteel-1
Copy link
Author

1 and 2 sound doubtfully: I have Graphene and /e/ on my phones,
4 the same, cause the result is the same on different networks in 2 different european countries..

@ignoramous
Copy link
Collaborator

Graphene and /e/ might have a subtly broken Download Manager... Very likely.

If you are technical enough, can you share adb logcat output as you attempt to download using the built-in Download Manager?

@hussainmohd-a
Copy link
Collaborator

hussainmohd-a commented Aug 17, 2023

Looks like we've run into a issue when the VPN is in lockdown mode and the 'Use in-app downloader' is turned off. Essentially, the Android download manager isn't kicking off downloads when this happens.

@A-7666, To double-check, if you start a download in lockdown mode and then try turning off the lockdown mode, the download manager will kickstart the pending download: #983

@ignoramous ignoramous added the bug Something isn't working label Aug 17, 2023
@RedSteel-1
Copy link
Author

RedSteel-1 commented Aug 31, 2023

@hussainmohd-a , oh ok.
Strange, cause I don't recall it to be the case before.
If I remember correctly, the blocklists on my other phone (which is now dead) were from 2022.12, maybe this is when this issue appeared in Rethink.

@ignoramous ,
Well I haven't noticed any issues with is other than with Rething blocklists so far.
Regarding the adb log, I can't do in in the near future sadly :-/

@iambeingtracked
Copy link

Hey, same issue here

I have a logcat of the problem http://0.vern.cc/E4.png

@ignoramous
Copy link
Collaborator

I have a logcat of the problem http://0.vern.cc/E4.png

Thanks. Looks like Rethink on your Android does not have access to read from / write to the Downloads folder? Rethink does request this permission, may be it has been revoked or not granted?

@iambeingtracked
Copy link

Exactly, it does not request the permission https://files.wherelinux.xyz/all-files-permissions.jpg

@ignoramous
Copy link
Collaborator

Exactly, it does not request the permission https://files.wherelinux.xyz/all-files-permissions.jpg

You're right.

Unsure why WRITE_EXTERNAL_STORAGE permission was removed in this commit: a9b1fe4

@ignoramous ignoramous added the P0 Priority: 0 (urgent and important) label Sep 2, 2023
@npahakis
Copy link

I downloaded Rethinkdns through fdroid on my Galaxy S20 (official ROM but debloated a bit) yesterday and wanted to manage blocklists, but the initial download would not do anything. Resetting the app wouldn't work either. The workaround then was to enable in-app downloader and suddenly it worked.
I dont recall having had these problems, the last time I hat to install the app in February.

What I noticed was, when I decided to stop the download that was going nothing and subsequently turned off the vpn, the download manager suddenly started downloading the files. This happens every time the blocklist download is started, aborted and the vpn stopped afterwards. But even if the download with deactivated vpn succeeded for all the files, the app couldn't work with that and started the process from scratch.

Why is vpn on even required for the blocklists to download? It seems like that was what prevented the download in the first place.

@Eollone
Copy link

Eollone commented Oct 23, 2024

我昨天在我的 Galaxy S20(官方 ROM,但有点膨胀)上通过 fdroid 下载了 Rethinkdns,想要管理阻止列表,但初始下载不会执行任何操作。重置应用程序也不起作用。当时的解决方法是启用应用内下载器,突然间它就起作用了。 我不记得上次在二月份安装该应用程序时遇到过这些问题。

我注意到,当我决定停止毫无进展的下载并随后关闭 VPN 时,下载管理器突然开始下载文件。每次阻止列表下载开始、中止以及随后 VPN 停止时都会发生这种情况。但即使使用停用的 VPN 成功下载所有文件,该应用程序也无法使用它并从头开始该过程。

为什么黑名单下载还需要打开 VPN?看来这就是阻止下载的首要原因。

I agree, currently downloading blocklist requires Rethink to be running in VPN mode first, which would make it impossible to use another VPN to proxy that download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 Priority: 0 (urgent and important)
Projects
None yet
Development

No branches or pull requests

6 participants