Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit tests #9963

Merged
merged 9 commits into from
Oct 21, 2022
Merged

Audit tests #9963

merged 9 commits into from
Oct 21, 2022

Conversation

eelanagaraj
Copy link
Contributor

@eelanagaraj eelanagaraj commented Oct 20, 2022

Description

  • focused on increasing branch coverage in the combiner domain tests since this was particularly low (increased this from 76 -> 80ish% overall, but 50% -> 80/90% specifically in the domain disable/quota endpoints)
  • generally audited combiner & signer tests and checked that we are testing for return values (not just status codes) & using strict object matching everywhere
  • reviewed the signer tests and tried to come up with any additional things that we need to test but I think we're generally good; I reduced the timeout time slightly on those tests since with the new timeout logic, we can timeout immediately)

Related issues

@eelanagaraj eelanagaraj requested a review from a team October 20, 2022 14:06
@eelanagaraj eelanagaraj changed the title Audit combiner tests Audit tests Oct 20, 2022
Copy link
Contributor

@alecps alecps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants