Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit ODIS 2.0.0 testing #9811

Closed
5 tasks done
Tracked by #8645
alecps opened this issue Aug 29, 2022 · 3 comments
Closed
5 tasks done
Tracked by #8645

Audit ODIS 2.0.0 testing #9811

alecps opened this issue Aug 29, 2022 · 3 comments
Assignees
@eelanagaraj
Labels
Component: Identity Component: ODIS ODIS 2.0.0
Milestone
Q3-M2 (17 Aug - 2...

Comments

@alecps
Copy link
Contributor

alecps commented Aug 29, 2022 •
edited by eelanagaraj
Loading

  • Make sure we're checking response values beyond just the status code everywhere
  • Make sure we're checking keyVersion header values in responses
  • Look for places where unit tests or further test cases would be useful
  • Make sure we're using strict object matching everywhere
  • Optionally reorganize the nesting of the combiner PNP/legacyPNP tests

The output of this ticket should be a PR and/or a sense of confidence that our testing is complete for the ODIS 2.0.0 refactor
@alecps alecps moved this from 🌟 New Issues to 🪜 This Milestone in 🔖 Identity - Team Aug 29, 2022
@alecps alecps mentioned this issue Aug 29, 2022
Closed
35 tasks
@arthurgousset
Copy link
Contributor

arthurgousset commented Sep 14, 2022 •
edited
Loading

Sprint planning:

  • Catch all ticket, towards the end after other audit tickets
  • Running code coverage testing locally
  • Eela went for 3 dev days
  • Alec went for 5 dev days: worried about unknown unknown
  • Izzy went for 5 dev days: lot of thinking, unexpected things

Todo:

  • Alec - Some boxes currently don't make sense

@alecps alecps self-assigned this Sep 16, 2022
@arthurgousset arthurgousset added this to the Q3-M2 (17 Aug - 28 Sep) milestone Sep 23, 2022
@arthurgousset
Copy link
Contributor

Sprint planning:

  • Alec split this up into combiner and signer tests

@eelanagaraj eelanagaraj moved this from 🪜 This Milestone to 🏃‍♀️ In Progress in 🔖 Identity - Team Oct 19, 2022
@arthurgousset
Copy link
Contributor

Sprint check-in:

  • Eela - mostly done with checking combiner tests (added a couple tests), waiting on key rotation ticket for some tests

@eelanagaraj eelanagaraj mentioned this issue Oct 20, 2022
Merged
@alecps alecps removed their assignment Oct 20, 2022
Repository owner moved this from 🏃‍♀️ In Progress to ✅ Closed in 🔖 Identity - Team Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eelanagaraj eelanagaraj

Labels
Component: Identity Component: ODIS ODIS 2.0.0
Projects
🔖 Identity - Team
Status: ✅ Closed
Milestone
Q3-M2 (17 Aug - 28 Sep)
Development

No branches or pull requests
3 participants
@eelanagaraj @alecps @arthurgousset