Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ContractKit (based on feedback) #840

Closed
4 of 6 tasks
mcortesi opened this issue Sep 4, 2019 · 2 comments
Closed
4 of 6 tasks

Document ContractKit (based on feedback) #840

mcortesi opened this issue Sep 4, 2019 · 2 comments
Assignees
Labels
devux Developer UX

Comments

@mcortesi
Copy link
Contributor

mcortesi commented Sep 4, 2019

Expected Behavior

Feeback to resolve:

  • There isn't any comprehensive documentation of all available functions and their signatures and behaviors for contractkit
  • There isn't any documentation listing all the core contracts that Celo provides
  • There isn't any documentation for creating and deploying smart contracts i.e. kit.web3.eth.Contract(...).deploy(...) (now Document how to deploy smart contract on Celo #1046 )
  • Sending money as described in the ContractKit docs does not work and always results in an error. It is also different from how sending money is implemented in the dAppKit Docs.
  • The first line of the sample code in the ContractKit Examples say that we can do
    const goldtoken = await kit.contract.getGoldToken()
    but the correct code should be
    const goldtoken = await kit.contracts.getGoldToken()
  • The sample code in the docs have missing imports
  • We couldnt find toTxResult even though it is used in the sample code, nor does it seem to be needed when sending transactions like this const result = await kit.web3.eth.sendSignedTransaction(tx);
@mcortesi mcortesi added the devux Developer UX label Sep 4, 2019
@mcortesi mcortesi self-assigned this Sep 4, 2019
@mcortesi
Copy link
Contributor Author

In progress...

For documentation we will use typedoc, and generate docs form .ts files.

typedoc by default generates an html static site, but in order to integrate it with gitbook I'm using a markdown plugin and having some problems with it.

Waiting for feedback on typedoc2md/typedoc-plugin-markdown#97

@mcortesi
Copy link
Contributor Author

mcortesi commented Oct 3, 2019

Partially fixed in #1195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devux Developer UX
Projects
None yet
Development

No branches or pull requests

1 participant