Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't revoke Last gold from voting for a group #2466

Closed
zviadm opened this issue Jan 17, 2020 · 3 comments
Closed

Can't revoke Last gold from voting for a group #2466

zviadm opened this issue Jan 17, 2020 · 3 comments

Comments

@zviadm
Copy link
Contributor

zviadm commented Jan 17, 2020

Expected Behavior

Running Checks:
   ✔  0682c9ed752e8a8bbb56bc33d83dd65379305f52 is a registered Account 
address: 0682c9ed752e8a8bbb56bc33d83dd65379305f52
votes: 
  0: 
    group: 0x1DBe73b0480058106798Adda62E25d5279233c1B
    pending: 2551706551664588093816 (~2551.71 10^18)
    active: 7750257155650008073441 (~7750.26 10^18)
  1: 
    group: 0x412f2910970F81e49Af9B46067d3fD4D7a281679
    pending: 0 
    active: 1 
Running Checks:
   ✔  0682c9ed752e8a8bbb56bc33d83dd65379305f52 is Signer or registered Account 
   ✔  0x412f2910970F81e49Af9B46067d3fD4D7a281679 is ValidatorGroup 
SendTransaction: revoke
txHash: 0x56d2fa13b7e1bb42ee0a7ca0d2118ff0ce47a1831a892bfd29aef5745892a5df
Sending Transaction: revoke... done
thezviad_gmail_com@cv-1:~/wotrust-ops$ celocli election:show --voter $v2
Running Checks:
   ✔  0682c9ed752e8a8bbb56bc33d83dd65379305f52 is a registered Account 
address: 0682c9ed752e8a8bbb56bc33d83dd65379305f52
votes: 
  0: 
    group: 0x1DBe73b0480058106798Adda62E25d5279233c1B
    pending: 2551706551664588093816 (~2551.71 10^18)
    active: 7750257155650008073441 (~7750.26 10^18)
  1: 
    group: 0x412f2910970F81e49Af9B46067d3fD4D7a281679
    pending: 0 
    active: 1 

I would have expected for that last vote to get revoked, but it doesn;t

@zviadm
Copy link
Contributor Author

zviadm commented Jan 19, 2020

btw this also allows to infinitely generate 1e-18 locked gold (however because transaction fees are more expensive it isn't a loop hole for making free money)

thezviad_gmail_com@cv-1:~$ celocli election:show --voter $gg
Running Checks:
   ✔  1dbe73b0480058106798adda62e25d5279233c1b is a registered Account 
address: 1dbe73b0480058106798adda62e25d5279233c1b
votes: 
  0: 
    group: 0x1DBe73b0480058106798Adda62E25d5279233c1B
    pending: 1900000000000000000000 (~1900 10^18)
    active: 27307432002837240617684 (~27307.43 10^18)
  1: 
    group: 0x4418a99aC82d042971668A78604d1baaA92B895f
    pending: 0 
    active: 1 
  2: 
    group: 0x412f2910970F81e49Af9B46067d3fD4D7a281679
    pending: 0 
    active: 2999999999999999999999 (~3000 10^18)
thezviad_gmail_com@cv-1:~$ celocli election:revoke --from $gg --for 0x4418a99aC82d042971668A78604d1baaA92B895f --value 1
Running Checks:
   ✔  1dbe73b0480058106798adda62e25d5279233c1b is Signer or registered Account 
   ✔  0x4418a99aC82d042971668A78604d1baaA92B895f is ValidatorGroup 
SendTransaction: revoke
txHash: 0x5698f8412ac63299e57dffe57d1b97ed4105e02c13743e04c77ca8907204da5a
Sending Transaction: revoke... done
thezviad_gmail_com@cv-1:~$ celocli lockedgold:show $gg
Running Checks:
   ✔  1dbe73b0480058106798adda62e25d5279233c1b is a registered Account 
lockedGold: 
  total: 32207432002837240617686 (~32207.43 10^18)
  nonvoting: 2 
  requirement: 20000000000000000000000 (~20000 10^18)
pendingWithdrawals: 

thezviad_gmail_com@cv-1:~$ celocli election:revoke --from $gg --for 0x4418a99aC82d042971668A78604d1baaA92B895f --value 1

Running Checks:
   ✔  1dbe73b0480058106798adda62e25d5279233c1b is Signer or registered Account 
   ✔  0x4418a99aC82d042971668A78604d1baaA92B895f is ValidatorGroup 
SendTransaction: revoke
txHash: 0x069b6200d642c02c58245ae4758bae48ecb012b461ebca124150e5e53792f887
Sending Transaction: revoke... done

thezviad_gmail_com@cv-1:~$ celocli lockedgold:show $gg
Running Checks:
   ✔  1dbe73b0480058106798adda62e25d5279233c1b is a registered Account 
lockedGold: 
  total: 32207432002837240617687 (~32207.43 10^18)
  nonvoting: 3 
  requirement: 20000000000000000000000 (~20000 10^18)
pendingWithdrawals: 

@daithi-coombes
Copy link

I can confirm the same:

$ celocli election:revoke --from $CELO_VALIDATOR_ADDRESS --for 0xBCD25468E4D433Ac442b87f32B37B39678BF7077 --value 1
Running Checks:
   ✔  813ea48dba2912060ce24f17e39a06efcb564e4a is Signer or registered Account 
   ✔  0xBCD25468E4D433Ac442b87f32B37B39678BF7077 is ValidatorGroup 
SendTransaction: revoke
txHash: 0xa233e7349c5020712a1294b5171df72a0f2d8d4e5350fbfc9ee098f0f7a62104
Sending Transaction: revoke... done

$ celocli election:show $CELO_VALIDATOR_ADDRESS --voter
Running Checks:
   ✔  813ea48dba2912060ce24f17e39a06efcb564e4a is a registered Account 
address: 813ea48dba2912060ce24f17e39a06efcb564e4a
votes: 
  0: 
    group: 0x3521a14aae3a4FaC3C6D0D6Ceb8642cDd21323A2
    pending: 0 
    active: 10648304537141800853334 (~10648.3 10^18)
  1: 
    group: 0xBCD25468E4D433Ac442b87f32B37B39678BF7077
    pending: 0 
    active: 1

@mrsmkl
Copy link
Contributor

mrsmkl commented Jan 27, 2020

Let's track the rounding error issue at #2507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants