-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ethstats operators SBAT receive stats from all elected validators #458
Ethstats operators SBAT receive stats from all elected validators #458
Comments
The description was slightly vague, so I made a sketch how I think the situation is/could be:
|
Thanks for writing this up! The description was a little vague because I hadn't figured out the details :-) There are a several open questions I think:
|
How do you associate the node key with the keys associated to the active validator set?
Maybe ethstats-operators can verify the signed auth token with some geth calls to a local full node (check validator group and sig, maybe on-chain blacklist)? |
Any more design to be done on this issue? |
We could have ethstats get the details from on-chain, but an alternative approach would be that ethstats has a 'trustedlist' of validators that it relies on as the source of truth for which nodes to accept stats from. So, how about every validator sends ethstats the list of enodes of all currently elected validators. This is available as Two extensions:
|
So to be clear, this approach uses the nodekey and not the validator key. Stats would be signed by the nodekey. The enode includes the node address which is derived from the nodekey, so we use that to check sigs. |
Thanks for the additional clarifications. Currently ethstats is a single stateless instance listening to a websocket.
|
I think the "trusted list" can be config that is read at startup (e.g a command line parameter)?
Yes, I am assuming there could be multiple operators but it's not essential if we defer supporting this to later.
The latter - every operator probably trusts a different subset of validators
Eventually, they should be able to contact multiple, but I would defer this to a later ticket |
The text was updated successfully, but these errors were encountered: