Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Release 55.0.0 #1893

Closed
amaitland opened this issue Dec 19, 2016 · 19 comments
Closed

Feature Request - Release 55.0.0 #1893

amaitland opened this issue Dec 19, 2016 · 19 comments

Comments

@amaitland
Copy link
Member

amaitland commented Dec 19, 2016

For those interested in sponsoring a 55.0.0 release then please check Bounty Source

There are a few conditions that need to be met before an official 55.0.0 release can happen.

If the set BountySource target is not met then all is not lost, you can of course build your own Nuget packages and host then on your local feed. If another contributor to the project wishes to take charge of the release then by all means say so and I'll happily close this issue.

Constructive comments welcome.

@amaitland amaitland added this to the 55.0.0 milestone Dec 19, 2016
@smaranh
Copy link
Contributor

smaranh commented Dec 19, 2016

you might also want to add it to the Readme.md.

@GrabzIt
Copy link
Contributor

GrabzIt commented Dec 19, 2016

@smaranh great idea!! I have added a PR to try to encourage people to contribute. Although if it's not appropriate I will close it.

@amaitland
Copy link
Member Author

Firstly thank you for the amazing show of support! As a gesture here is a link to the General Usage Guide I had been working on, it started as a port of https://bitbucket.org/chromiumembedded/cef/wiki/GeneralUsage and now has many CefSharp specific details.

https://gist.github.com/amaitland/aa976285407ba35cf895c67c614ba82c

Please review at your leisure, if you have any requests for topics you'd like to see covered then let me know. This Guide will be included as part of the release and will replace large parts of the existing FAQ (The Javascript specific parts at a minimum).

If/when 50% of the target is reached I will release a new -pre set of packages to Nuget. The crashpad issue listed above would require you to add a small block of code to your application to deal with launching of the new crashpad process type. It's relatively trivial, and details are in #1876 (comment) Is everyone happy to see a -pre release before this issue is resolved? There will be a application crash if the additional code isn't added. Feedback welcome 👍

@amaitland
Copy link
Member Author

If/when 75% of the target is met I will attempt to add GitLink support as outlined in #1680

In theory GitLink will allow you to step through the CefSharp code hosted on GitHub by rewriting the pdb source file locations.

@jankurianski
Copy link
Member

My company appreciates all the effort 👍

@joe-williams-cccu
Copy link

@jankurianski Thank you and your colleagues!

@amaitland
Copy link
Member Author

GitLink support has been added, so you can now step into the code when developing. See #1680 for full details.

@amaitland
Copy link
Member Author

Crashpad support has been resolved upstream, hopefully the changes will appear in the 2883 branch shortly.

https://bitbucket.org/chromiumembedded/cef/issues/1995/migrate-from-breakpad-to-crashpad#comment-33539720

@amaitland
Copy link
Member Author

master has been upgraded to 3.2883.1542 which is based on Chromium 55.0.2883.87 (The current stable release). Just waiting on the crashpad changes to be merged into 2883 before a -pre set of packages is available.

@amaitland
Copy link
Member Author

Upgraded to CEF 3.2883.1545 for which crashpad is now disabled by default.

  • New cefsharp/55 branch has been created
  • I've tagged 55.0.0-pre01 and the packages should appear on MyGet shortly. They still require testing before uploading to Nuget.org

@amaitland
Copy link
Member Author

The 55.0.0-pre01 packages have been pushed to Nuget.org, should appear in the next few hours (they're awaiting indexing).

Please test them out and report back. If you do encouner a bug then please make sure you fill out the Bug Report when opening an issue.

@amaitland
Copy link
Member Author

Does anyone have feedback? I will look to update to the latest CEF build and release the final version in about a week.

@philipbeber
Copy link
Contributor

I tried 55.0.0-pre01 with our app and it worked great! Looking forward to the final release :)

@amaitland
Copy link
Member Author

@amaitland
Copy link
Member Author

Going with 3.2883.1552 instead as the two newer commits are for MacOS and fixing a bug introduced by the MacOS change.

cefsharp/55 and master have been updated, see 2ded106 for the relevant details.

@danielearwicker
Copy link

I'm in the early days of trying this out. I have to say on what I've seen so far, this project is nothing short of a miracle. Thank you!

Also 55.0.0-pre01 seems fine and fixes #1819. 😎

@amaitland
Copy link
Member Author

Packages have been generated, will confirm when they're pushed to Nuget.org.

https://ci.appveyor.com/project/cefsharp/cefsharp/build/55.0.0-CI2139

@amaitland
Copy link
Member Author

Packages have been pushed to Nuget.org, they should appear shortly (takes a while before they're indexed)

Check out the Release Notes which as always includes a list of Known Issues. If you find a bug then please fill out the Issue Template when opening an issue.

I'll leave this open for a week to let the dust settle.

@amaitland
Copy link
Member Author

Generated API Doc is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants