Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download fails when plugin directory name includes punctuation characters (or anything outside sanitize_key()) #108

Closed
lkraav opened this issue Aug 23, 2019 · 3 comments

Comments

@lkraav
Copy link

lkraav commented Aug 23, 2019

Hi. As identified in #83, I think we could use a add_filter sanitize_key to perhaps add more elements to the whitelist. For example, some of our plugins are named something-other.git, to distinguish it from something-other aka clean upstream version. Your thoughts?

@lkraav
Copy link
Author

lkraav commented Aug 23, 2019

Aah, I see now be16e11 moves away from sanitize_key(), which means we could use a custom filter, or just hardcode to add the . character, since it's likely to be used elsewhere also.

@bradyvercher
Copy link
Member

Composer does allow . in package names, so I don't think there should be an issue hardcoding that. If you modify that regex to include ., does it solve your use case?

@lkraav
Copy link
Author

lkraav commented Aug 23, 2019

Yes, it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants