Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more clarity on which specific validation failed #65

Closed
grzuy opened this issue Aug 15, 2018 · 2 comments · Fixed by #116
Closed

Provide more clarity on which specific validation failed #65

grzuy opened this issue Aug 15, 2018 · 2 comments · Fixed by #116

Comments

@grzuy
Copy link
Contributor

grzuy commented Aug 15, 2018

No description provided.

@grzuy grzuy changed the title Raise user-friendly errors when validation fails Return user-friendly errors when validation fails Aug 15, 2018
@grzuy grzuy changed the title Return user-friendly errors when validation fails Provide more clarity on which specific validation failed Aug 15, 2018
@grzuy grzuy added this to the 1.0 milestone Aug 15, 2018
@grzuy
Copy link
Contributor Author

grzuy commented Oct 22, 2018

As per @brauliomartinezlm recommendation in #80 (comment) we may want to consider raising exceptions for each specific invalid condition in the responses.

@grzuy
Copy link
Contributor Author

grzuy commented Oct 30, 2018

I am thinking we can:

  • define new methods #verify which raise on any verification error on the responses.
  • keep current #valid? methods, which:
    • just calls #verify and catches verification errors and continues to expose the same behavior to the user returning true or false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant