Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support removing image on delete (RemovalPolicy.DESTROY) #215

Open
athewsey opened this issue Oct 14, 2022 · 0 comments
Open

Support removing image on delete (RemovalPolicy.DESTROY) #215

athewsey opened this issue Oct 14, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@athewsey
Copy link

Hi folks,

I have a stack that uses ECRDeployment to upload an image to an ecr.Repository that's been created with RemovalPolicy.DESTROY.

Unfortunately, this is making stack deletion fail because the ECR repository is not emptied out. As far as I can tell, this construct offers no removalPolicy parameter and the Custom resource Lambda entry point ignores delete requests.

Is my assessment right? Would it be possible to implement resource deletion, perhaps behind a removalPolicy option so that only users who explicitly request deletion see it? The repo and image are fully managed by the CDK app in our current case, so it'd be much preferred for the app to clean up after itself when destroyed. Thanks!

@mrgrain mrgrain added enhancement New feature or request help wanted Extra attention is needed labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants