From 80d2c6e0a1a10b7378534a265e11127280f19af1 Mon Sep 17 00:00:00 2001 From: Philippe Antoine Date: Thu, 21 Mar 2024 22:45:41 +0100 Subject: [PATCH] rust/mqtt: fix clippy 1.77 warning error: creating a mutable reference to mutable static is discouraged --> src/mqtt/mqtt.rs:752:23 | 752 | let max_msg_len = &mut MAX_MSG_LEN; | ^^^^^^^^^^^^^^^^ mutable reference to mutable static | = note: for more information, see issue #114447 = note: this will be a hard error in the 2024 edition = note: this mutable reference has lifetime `'static`, but if the static gets accessed (read or written) by any other means, or any other reference is created, then any further use of this mutable reference is Undefined Behavior --- rust/src/mqtt/mqtt.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/rust/src/mqtt/mqtt.rs b/rust/src/mqtt/mqtt.rs index 8260251218bd..35f3c6d459a8 100644 --- a/rust/src/mqtt/mqtt.rs +++ b/rust/src/mqtt/mqtt.rs @@ -749,8 +749,7 @@ export_state_data_get!(rs_mqtt_get_state_data, MQTTState); #[no_mangle] pub unsafe extern "C" fn rs_mqtt_register_parser(cfg_max_msg_len: u32) { let default_port = CString::new("[1883]").unwrap(); - let max_msg_len = &mut MAX_MSG_LEN; - *max_msg_len = cfg_max_msg_len; + MAX_MSG_LEN = cfg_max_msg_len; let parser = RustParser { name: PARSER_NAME.as_ptr() as *const std::os::raw::c_char, default_port: default_port.as_ptr(),