Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify time is universal, not by course and activity #143

Open
Urpokarhu1 opened this issue Jan 10, 2024 · 3 comments
Open

Notify time is universal, not by course and activity #143

Urpokarhu1 opened this issue Jan 10, 2024 · 3 comments

Comments

@Urpokarhu1
Copy link

Hello,

I have noticed a bug, notify time is universal for whole system and activity. It should be per activity, not per system.

@Urpokarhu1 Urpokarhu1 changed the title Notify time is univeral, not by course and activity Notify time is universal, not by course and activity Jan 10, 2024
@danmarsden
Copy link
Member

this could be related to #149 - but we really need a bit more info to be able to reproduce this ... It would be good if you could try to reproduce with the latest code now that #149 has landed.

@Urpokarhu1
Copy link
Author

Urpokarhu1 commented Apr 17, 2024

Hello,

Is tested again with version mod_reengagement 2023020804 and problem persists.

  1. Create course1 and course2
  2. Create re-engagement on course1 with settings:
  • notify user: after delay 5 minutes
  • reminder count: 1
  • activity completion
  • Reengagement duration: 20 minutes.
  1. Notice the date and time in "notify time"-column. for example 24/04/24, 10:15

  2. Create re-engagement on course2 with settings:

  • notify user: after delay 15 minutes
  • reminder count: 1
  • activity completion
  • Reengagement duration: 20 minutes.
  1. Notice how "notify time" is identical to a course1 re-engagement-activity for example 24/04/24, 10:15 and not what it should be according to re-engagement-activity settings on this course.

course1
image

course2
image

@Urpokarhu1
Copy link
Author

You should also check #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants