Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s version bump and CVE fix #1052

Merged
merged 4 commits into from
Feb 6, 2025
Merged

k8s version bump and CVE fix #1052

merged 4 commits into from
Feb 6, 2025

Conversation

ankitsny
Copy link
Contributor

@ankitsny ankitsny commented Jan 27, 2025

What this PR does / why we need it:

  1. Run all tests on minimum k8s required version(1.27.0) and the latest version of k8s(1.32.0)
  2. CVE fix https://github.com/carvel-dev/kapp/security/dependabot/9
  3. Using kind instead of minikube.
  4. Refactored GitHub action workflow.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?

NA


Additional Notes for your reviewer:

We had 2 workflow to run the tests on minimum and the latest k8s version, In this PR, I am using Matix Strategy, where we can specify the multiple versions and the test will run for all the specified version in parallel.

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@ankitsny ankitsny changed the title K8s version bump K8s version bump and CVE fix Jan 27, 2025
@ankitsny ankitsny force-pushed the k8s-version-bump branch 6 times, most recently from f62a9ed to 87d5512 Compare January 27, 2025 07:21
@ankitsny ankitsny requested review from praveenrewar and devanshuVmware and removed request for praveenrewar January 27, 2025 07:23
@ankitsny ankitsny marked this pull request as ready for review January 27, 2025 07:23
@ankitsny ankitsny changed the title K8s version bump and CVE fix k8s version bump and CVE fix Jan 27, 2025
Copy link
Contributor

@devanshuVmware devanshuVmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@100mik
Copy link
Contributor

100mik commented Feb 6, 2025

Let me know if you can make this change, I am alright without this as well

@ankitsny ankitsny requested a review from 100mik February 6, 2025 06:30
Signed-off-by: Ankit Kumar <[email protected]>
@100mik 100mik merged commit d7fc2e1 into develop Feb 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants