-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k8s version bump and CVE fix #1052
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f25f57
to
ad1362f
Compare
Signed-off-by: Ankit Kumar <[email protected]>
Signed-off-by: Ankit Kumar <[email protected]>
f62a9ed
to
87d5512
Compare
87d5512
to
a4243ec
Compare
devanshuVmware
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ankit Kumar <[email protected]>
a4243ec
to
c755f4b
Compare
100mik
reviewed
Feb 6, 2025
Let me know if you can make this change, I am alright without this as well |
Signed-off-by: Ankit Kumar <[email protected]>
eb2bf00
to
ff62216
Compare
100mik
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
NA
Additional Notes for your reviewer:
We had 2 workflow to run the tests on minimum and the latest k8s version, In this PR, I am using Matix Strategy, where we can specify the multiple versions and the test will run for all the specified version in parallel.
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: