Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain executable flag on files in bundle #93

Closed
benmoss opened this issue Feb 24, 2021 · 3 comments
Closed

Retain executable flag on files in bundle #93

benmoss opened this issue Feb 24, 2021 · 3 comments
Assignees
Labels
breaking change carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request

Comments

@benmoss
Copy link
Contributor

benmoss commented Feb 24, 2021

Describe the problem/challenge you have
Right now when you do an imgpkg push to create a bundle it will drop the executable flag on any files, it is hard-coded to create every file in the tarball with 0600: https://github.com/vmware-tanzu/carvel-imgpkg/blob/499b334d53c78a9624f427e96dcb6e1a87dd6d50/pkg/imgpkg/image/tar_image.go#L129

Describe the solution you'd like
The executable flag should be kept on the files

Anything else you would like to add:
Slack thread: https://kubernetes.slack.com/archives/CH8KCCKA5/p1614181788053900

@benmoss benmoss added carvel triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Feb 24, 2021
@joaopapereira
Copy link
Member

Looks good to me.

We should ensure the following:

  • Only add execution permission to files that had execution permission previously

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this bug fixed as soon as possible"
👎 "There are more important bugs to focus on right now"

We are also happy to receive and review Pull Requests if you want to help fix this issue.

@joaopapereira joaopapereira added carvel accepted This issue should be considered for future work and that the triage process has been completed and removed carvel triage This issue has not yet been reviewed for validity labels Feb 25, 2021
@aaronshurley
Copy link
Contributor

When you pick up this story, discuss the possibility of keeping the ownership bits.

@joaopapereira
Copy link
Member

Shipped with version 0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request
Projects
None yet
Development

No branches or pull requests

4 participants