Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new package to source the domains #308

Open
8 tasks
brunomenezes opened this issue Jan 20, 2025 · 0 comments
Open
8 tasks

Add a new package to source the domains #308

brunomenezes opened this issue Jan 20, 2025 · 0 comments
Assignees
Labels
apps: web Type: Refactor Code changes that neither adds a new feature nor fix a bug.

Comments

@brunomenezes
Copy link
Collaborator

📄 Context

All API domain-related code, such as types and graphQL queries, is generated inside the web app. Using a structure of scoped packages causes type duplication and quickly causes out-of-sync issues, mainly between the web and packages/ui. As complexity tends to increase with multi-version support, the earlier the reorg, the less is built on top of the current organization.

✔️ Solution

Create a new scoped package for the explorer and rollup-app domain and its outputs, e.g. data types, graphQL queries/documents/hooks, etc.

  • Scope name: @cartesi/rollups-explorer-domain.
  • Package folder name: domain

📈 Subtasks

  • Move current code generation to the new package.
  • Prepare the package to build the artefacts for distribution between other packages / Apps.
  • Update turborepo as necessary.
  • Replace imports in the apps/web.

🎯 Definition of Done

  • New package that generates the artefacts for distribution correctly.
  • Imports replaced without any regression added.
  • CI tests are passing.
  • Vercel builds are passing.
@brunomenezes brunomenezes added apps: web Type: Refactor Code changes that neither adds a new feature nor fix a bug. labels Jan 20, 2025
@brunomenezes brunomenezes self-assigned this Jan 20, 2025
@github-project-automation github-project-automation bot moved this to 📌 Todo in Explorer Unit Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: web Type: Refactor Code changes that neither adds a new feature nor fix a bug.
Projects
Status: 📌 Todo
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant