Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] tag fastpair==0.1.0 causing on issue on install #29

Closed
jGaboardi opened this issue May 29, 2024 · 2 comments · Fixed by #30
Closed

[INFRA] tag fastpair==0.1.0 causing on issue on install #29

jGaboardi opened this issue May 29, 2024 · 2 comments · Fixed by #30
Assignees

Comments

@jGaboardi
Copy link
Collaborator

While working on (3.) in #20, I am running into the problem of there being no associated dynamic version with the fastpair==0.1.0 tag, which is causing the pip install -e . to fail.

The two options (IMHO) are a conservative approach [1,2] or a more aggressive approach [2] that does it all at once.

  1. conservative approach (2 PRs):
    1. explicitly declaring version = "v0.1.0" in pyproject.toml in a first PR addressing (3.)
    2. (perhaps create a v0.1.1 tag and associated release, but this might be overkill)
    3. proceed to step 2
  2. one stroke (1 PR):
    1. delete the fastpair==0.1.0 tag (remote & local)
    2. declare dynamic = ["version"] in pyproject.toml

@carsonfarmer Let me know if (A) you have any questions/concerns here; and (B) which approach you'd like me to take.

@carsonfarmer
Copy link
Owner

Since we didn't have tags and releases before, I don't see any reason not to just go with option 2. But I'm happy to adopt either, I leave it up to you.

@jGaboardi
Copy link
Collaborator Author

I'll go with option 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants