Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailtos from= and name= used together generate warning #1207

Closed
ilium007 opened this issue Sep 28, 2024 · 3 comments
Closed

mailtos from= and name= used together generate warning #1207

ilium007 opened this issue Sep 28, 2024 · 3 comments
Labels

Comments

@ilium007
Copy link

📣 Notification Service(s) Impacted
mailtos

🐞 Describe the bug
When using from= and name= together the following warning is logged:


WARNING
Email name= and from= are synonymous; use one or the other.

💡 Screenshots and Logs

WARNING
Email name= and from= are synonymous; use one or the other.

💻 Your System Details:
Docker

🔮 Additional context
name and from and not synonomous, I want "name" to appear in my email inbox as a name, not a from email address

@ilium007 ilium007 added the bug label Sep 28, 2024
@caronc
Copy link
Owner

caronc commented Sep 29, 2024

They actually are synonymous of each other just due to the way email is parsed. I could attempt to get rid the the warning if the conflicting conditions aren't met.

Emails can be in the following format:

Both from and name were originally not so smart of parameters, but now, both populate/parse what is specified from:

  • name <from> if both are detected
  • name if not detected an email
  • from if detected an email.

I realize this is long winded, but just trying to explain why it's synonymous:

It can be written like this instead (no warning):

The only reason i kept name around was to be compatible with older configurations people may have.

@caronc
Copy link
Owner

caronc commented Oct 4, 2024

I decided I'd just drop the warning per your comment; it's really not that big of a deal at the end of the day. 👍

Closing off ticket as complete 🚀

@caronc caronc closed this as completed Oct 4, 2024
@ilium007
Copy link
Author

ilium007 commented Oct 4, 2024

I just didn't realise the correct format for the email address: John Doe <[email protected]>

This fixed it all for me. Not sure if doco covers this format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants