Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic prometheus /metrics added #188

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Conversation

nghduc97
Copy link
Contributor

@nghduc97 nghduc97 commented May 1, 2024

Description:

#143

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • Tests added

@caronc
Copy link
Owner

caronc commented May 2, 2024

Just curious what is being monitored. Apprise-API has no backend database to collect statistics to be shared through Prometheus.

@nghduc97
Copy link
Contributor Author

nghduc97 commented May 2, 2024

It can be used to monitor uptime, HTTP traffic/errors like when 400s or 500s status code.

Some other metrics like python GC stats come with the default too, though I don't need it for a program this size.

@instantdreams
Copy link

What would the endpoint be for this? http://[container-ip]:[container-port]/metrics?

I'd very much like to see this implemented.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (ecc8655) to head (b77719d).
Report is 37 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   99.37%   99.74%   +0.37%     
==========================================
  Files           7       11       +4     
  Lines         794     1161     +367     
==========================================
+ Hits          789     1158     +369     
+ Misses          5        3       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit 9147575 into caronc:master Feb 18, 2025
3 checks passed
@caronc
Copy link
Owner

caronc commented Feb 18, 2025

Made some minor changes and merged it. Sorry to take so long to review this. The expressed interest brought your efforts back to life.

Great work and thanks for the PR! 🙏 🚀

@caronc caronc changed the title add basic prometheus metrics Basic prometheus /metrics added Feb 18, 2025
@caronc caronc mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants