Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for legacy voices. #140

Closed
4 tasks done
patrik-malina opened this issue Jul 23, 2024 · 4 comments · Fixed by #141
Closed
4 tasks done

Support for legacy voices. #140

patrik-malina opened this issue Jul 23, 2024 · 4 comments · Fixed by #141

Comments

@patrik-malina
Copy link

System Health details

/

Checklist

  • I have enabled debug logging for my installation.
  • I have filled out the issue template to the best of my ability.
  • This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
  • This issue is not a duplicate issue of currently previous issues..

Describe the issue

I'm having problem using legacy voices. Used Jeremy voice:

Could not find voice with name {}, available voices: ['Sarah', 'Laura', 'Charlie', 'George', 'Callum', 'Liam', 'Charlotte', 'Alice', 'Matilda', 'Will', 'Jessica', 'Eric', 'Chris', 'Brian', 'Daniel', 'Lily', 'Bill']

I thing this need to implement in code (i'm not coder):
curl --request GET \ --url 'https://api.elevenlabs.io/v1/voices?show_legacy=true'

Reproduction steps

/

Debug logs

/

Diagnostics dump

No response

@patrik-malina
Copy link
Author

Actually I did it :)

But it can be done more elegant, with say option for legacy voices in config.

How is done:
changed file elevenlabs.py in line 95 to:
endpoint = "voices?show_legacy=true"
restarted HA and mine favorite voice is back again :)

@patrik-malina patrik-malina changed the title No more legacy voices. Support for legacy voices. Jul 24, 2024
@carleeno
Copy link
Owner

@patrik-malina thanks
Looking into it, it doesn't seem that there's a good way to get the config options during the stage where it fetches the list of voices....so I think we'll just have to turn it on for all, and maybe append (Legacy) to the name to differentiate them. But changing the names like that will also break user configs that already have a legacy voice set. Although I suspect since it's already broken it's not a big deal to change it. What do you think?

@carleeno
Copy link
Owner

carleeno commented Jul 24, 2024

@patrik-malina I think I found a non-breaking way to add support for legacy with the " (Legacy)" suffix...

Can you give this prerelease a try?
https://github.com/carleeno/elevenlabs_tts/releases/tag/2.4.0-pre.1

It should show the (Legacy) suffix next to the old voices, and selecting them that way (with the suffix) should work, as well as specifying the name without the suffix directly in config should work as well.

This also updates the default model, feel free to give that a try as well to see if it's faster.

@patrik-malina
Copy link
Author

@carleeno Can confirm, that this works. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants