Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor environment variable CARGO #452

Closed
NobodyXu opened this issue Sep 30, 2022 · 0 comments · Fixed by #453
Closed

Honor environment variable CARGO #452

NobodyXu opened this issue Sep 30, 2022 · 0 comments · Fixed by #453
Labels
Report: enhancement Request for improvements to existing features or code

Comments

@NobodyXu
Copy link
Member

According to Environment variables Cargo sets for 3rd party subcommands, cargo sets environment variable CARGO for subcommands.

detect-targets and cargo-binstall probably need to use this environment variable when present.

detec-targets needs to run $CARGO -vV, which also prints host: just as rustc -vV to stdout:

cargo 1.64.0 (387270bc7 2022-09-16)
release: 1.64.0
commit-hash: 387270bc7f446d17869c7f208207c73231d6a252
commit-date: 2022-09-16
host: aarch64-apple-darwin
libgit2: 1.4.2 (sys:0.14.2 vendored)
libcurl: 7.79.1 (sys:0.4.55+curl-7.83.1 system ssl:(SecureTransport) LibreSSL/3.3.6)
os: Mac OS 12.6.0 [64-bit]

Where as cargo-binstall needs to run $CARGO install ....

@NobodyXu NobodyXu added the Report: enhancement Request for improvements to existing features or code label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Report: enhancement Request for improvements to existing features or code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant