Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tokens] Implement lighten/darken method for color change across states. Deprecate Hover tokens. #4049

Closed
shixiedesign opened this issue Sep 20, 2019 · 2 comments · Fixed by #5269
Labels

Comments

@shixiedesign
Copy link
Contributor

shixiedesign commented Sep 20, 2019

New color palette is implemented here #3904 . The only place where this change is not carrying through are in the Hover states because those colors are hard coded.

  • Implement lighten/darken method for color change on hover states.
  • Deprecate Hover tokens
@sadekbazaraa
Copy link

sadekbazaraa commented Jan 30, 2020

@vpicone here's the Sketch file that we went over outlining the (L)ightness value adjustments for the V2 palette hover states.

IBM V2 Hover Colors.zip

And here's a sample from the file for reference. In this example you can see that the hover value for Red 60 has an adjusted lightness value of -8%.

Screen Shot 2020-01-30 at 5 48 35 PM

@vpicone
Copy link
Contributor

vpicone commented Feb 4, 2020

@carbon-design-system/developers-system

Right now the interactive tokens are hard coded which means when we shifted to v2 colors, they remained the same.

These colors don’t exist in either pallet, adding them would require increasing the resolution of the pallet and doubling the amount colors. This defeats the purpose of a restricted pallet.

Opened #5269 to address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants