Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datable compost: Replace straight quotes with apostrophe #3920

Closed
mjabbink opened this issue Sep 5, 2019 · 3 comments · Fixed by #4734
Closed

datable compost: Replace straight quotes with apostrophe #3920

mjabbink opened this issue Sep 5, 2019 · 3 comments · Fixed by #4734
Assignees
Labels
severity: 4 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@mjabbink
Copy link

mjabbink commented Sep 5, 2019

https://www.carbondesignsystem.com/components/data-table/code

@alisonjoseph

see below: "Maureen’s VM Groups..."
Screen Shot 2019-09-05 at 11 34 02 AM

@alisonjoseph
Copy link
Member

This is pulling in from the core carbon library, transferring the issue over to that repo

@alisonjoseph alisonjoseph transferred this issue from carbon-design-system/carbon-website Sep 5, 2019
@tw15egan tw15egan added severity: 4 https://ibm.biz/carbon-severity type: bug 🐛 labels Sep 5, 2019
@joshblack joshblack self-assigned this Nov 19, 2019
@joshblack
Copy link
Contributor

Seems like this conflicts with prettier rules which is what handles text formatting, would cause issues in our codebase and for downstream folks as it would try and format the apostrophe to a straight quote, would we still want to go forward with this?

@vpicone
Copy link
Contributor

vpicone commented Nov 20, 2019

@joshblack The only reason that string was double quotes was to allow for the dumb quote in the middle without breaking it up. Using the 'smart quote' in the string actually means we can use single quotes to wrap the string (prettier's setting and the format for the rest of the file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity: 4 https://ibm.biz/carbon-severity type: bug 🐛
Projects
None yet
5 participants