Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[All inputs, vanilla & react] Remove hover states #2717

Closed
6 tasks done
shixiedesign opened this issue May 14, 2019 · 2 comments · Fixed by #2850
Closed
6 tasks done

[All inputs, vanilla & react] Remove hover states #2717

shixiedesign opened this issue May 14, 2019 · 2 comments · Fixed by #2850
Assignees
@emyarod
Labels
package: react carbon-components-react severity: 3 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@shixiedesign
Copy link
Contributor

shixiedesign commented May 14, 2019 •
edited by emyarod
Loading

No inputs should have hover state styling except the cursor type change. Currently noticing text input, text area, and number inputs have background color change. Should be removed. Date picker is correct.

  • text input
  • text area
  • number input
  • date picker
  • slider
  • search

Correct spec for all inputs' hover states:

image
@emyarod emyarod mentioned this issue May 14, 2019
Merged
26 tasks
@emyarod
Copy link
Member

emyarod commented May 28, 2019

just to confirm, is this the correct hover behavior for the search input clear button?

Kapture 2019-05-28 at 9 36 27

@emyarod emyarod self-assigned this May 28, 2019
@emyarod emyarod mentioned this issue May 28, 2019
Merged
@shixiedesign
Copy link
Contributor Author

@emyarod nope lol! Should be this:

image

@dakahn dakahn added priority: high severity: 3 https://ibm.biz/carbon-severity labels May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
package: react carbon-components-react severity: 3 https://ibm.biz/carbon-severity type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove input field hover states emyarod/carbon
3 participants
@emyarod @shixiedesign @dakahn