Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the DataTable Row Cell data model #2645

Closed
ajdaniel opened this issue Mar 27, 2018 · 5 comments
Closed

Update the DataTable Row Cell data model #2645

ajdaniel opened this issue Mar 27, 2018 · 5 comments
Labels
package: react carbon-components-react status: inactive Will close if there's no further activity within a given time type: enhancement 💡

Comments

@ajdaniel
Copy link
Contributor

Detailed description

As of the discussion in #737 the data model for a row cell in DataTable ought to be updated to a new structure:

{
  id: string,
  value: any,
  state: {  // new stuff
    isEditable: boolean,
    isEditing: boolean,
    isValid: boolean,
    errors: Array<CellError>,
  },
  info: {
    header: string,
  },
}

If the structure of existing properties change, this will be a breaking change. We could either put this change in a major release, or better yet, have this structure, which has the old and new model, but should indicate the old model is now deprecated, and will be removed in the next major release.

{
  id: string,
  value: any,
  isEditable: boolean, // deprecated
  isEditing: boolean, // deprecated
  isValid: boolean, // deprecated
  errors: Array<CellError>, // deprecated
  state: {  // new stuff
    isEditable: boolean,
    isEditing: boolean,
    isValid: boolean,
    errors: Array<CellError>,
  },
  info: {
    header: string,
  },
}
@joshblack
Copy link
Contributor

Hi @ajdaniel! 👋 Thanks so much for taking the time to write this out. We really appreciate it 🙌

Definitely think we can introduce this stuff in soon, and just deprecate access to the other fields with a warning message until the next major release.

@stale
Copy link

stale bot commented May 2, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

@carbon-bot carbon-bot transferred this issue from carbon-design-system/carbon-components-react May 9, 2019
@carbon-bot
Copy link
Contributor

Hi there! 👋 If you're wondering why this issue was moved, we're currently updating our repo structure so that every package is found in the same project.

This should not have any impact for you, but we wanted to give you a heads up in case you were wondering what is going on. If you have any questions, feel free to reach out to us on Slack or contact us at: [email protected]. Thanks!

@stale
Copy link

stale bot commented Jun 8, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jun 8, 2019
@stale
Copy link

stale bot commented Jun 11, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

@stale stale bot closed this as completed Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react carbon-components-react status: inactive Will close if there's no further activity within a given time type: enhancement 💡
Projects
None yet
Development

No branches or pull requests

3 participants