Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate shared dropdown and list-box styles #2197

Closed
emyarod opened this issue Mar 25, 2019 · 3 comments
Closed

Consolidate shared dropdown and list-box styles #2197

emyarod opened this issue Mar 25, 2019 · 3 comments
Assignees
@emyarod
Labels
status: inactive Will close if there's no further activity within a given time

Comments

@emyarod
Copy link
Member

emyarod commented Mar 25, 2019 •
edited
Loading

our React DropdownV2 and vanilla Dropdown components inherit two distinct sets of styles despite having near-identical markup now. It may be better to inherit the same set of styles without overrides and high specificity style declarations

temporary workaround in #2203
@emyarod emyarod added the version: 10 Issues pertaining to Carbon v10 label Mar 25, 2019
@emyarod emyarod added this to the v10.0-rc1 milestone Mar 25, 2019
@emyarod emyarod self-assigned this Mar 25, 2019
@emyarod emyarod mentioned this issue Mar 25, 2019
Merged
@emyarod emyarod modified the milestones: v10.0-rc1, v10-update Mar 25, 2019
@asudoh asudoh added type: research 👓 and removed version: 10 Issues pertaining to Carbon v10 labels Mar 25, 2019
@asudoh asudoh removed this from the v10-update milestone Mar 25, 2019
@stale
Copy link

stale bot commented May 1, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

@stale stale bot added the wontfix label May 1, 2019
@dakahn dakahn removed the wontfix label May 6, 2019
@stale
Copy link

stale bot commented May 20, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label May 20, 2019
@stale
Copy link

stale bot commented May 23, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

@stale stale bot closed this as completed May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
status: inactive Will close if there's no further activity within a given time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asudoh @emyarod @dakahn