Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental inline select - Determine how we do spacing around invalid icon #1885

Closed
asudoh opened this issue Feb 22, 2019 · 9 comments
Closed
Labels
status: inactive Will close if there's no further activity within a given time

Comments

@asudoh
Copy link
Contributor

asudoh commented Feb 22, 2019

From @laurenmrice #1756 (review)

The spacing of the Inline Selects is still off. For all inline selects the icon will be 8 px / .5 rem away from the last letter in the field. Right now there is too much space between them.

We need to see if it can be done with a reasonable implementation (devs suspect not), and if it's yes, we should implement that.

@emyarod
Copy link
Member

emyarod commented Feb 26, 2019

I think we most likely need to consider moving away from native <select> to implement this

@asudoh
Copy link
Contributor Author

asudoh commented Feb 26, 2019

Though it's a fair intuition (I used to have the same one as yours), native <select> usage is the only differentiating factor between select and dropdown AFAIK.

@emyarod
Copy link
Member

emyarod commented Feb 26, 2019

are there major reasons for choosing to use the native <select>? if we do decide to create a custom Select component, I believe there are still major differentiators between a Select component and a Dropdown that we could implement post-v10 (I think the dropdown name could be rolled into OverflowMenu or vice-versa)

@asudoh
Copy link
Contributor Author

asudoh commented Feb 26, 2019

The team said it's for a11y back when before I joined Carbon team. @tw15egan do you recall any...? Thanks!

@tw15egan
Copy link
Contributor

I think the main reasoning is that if it's being used in a form, semantically, it should be using the HTML5 form element. In this case, select. If this component is being used outside of a form, perhaps it should be moved under dropdown, and be changed to inline dropdown.

If we can achieve the same a11y with a custom solution, I'm all for it, but I would defer to @dakahn

@dakahn
Copy link
Contributor

dakahn commented Mar 1, 2019

A usable and accessible select control using a custom widget (like our Dropdown) is a thing that can happen, but it would take careful testing and you'd end up having to code a lot of screen reader friendly aria tech and bespoke keyboard controls that you get for free by using <select>. Some of that is already in there so that argument could be made. 🤷🏽‍♂️

If there's a user need for a fully customizable select control -- in terms of visual presentation -- then we can explore that, but I'd push back pretty strongly on any custom keyboard interaction patterns that don't meet a user's expectation for a <select> control in a form.

@stale
Copy link

stale bot commented May 1, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

@stale stale bot added the wontfix label May 1, 2019
@dakahn dakahn removed the wontfix label May 6, 2019
@stale
Copy link

stale bot commented May 20, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label May 20, 2019
@stale
Copy link

stale bot commented May 23, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

@stale stale bot closed this as completed May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: inactive Will close if there's no further activity within a given time
Projects
None yet
Development

No branches or pull requests

4 participants