Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y]: HeaderSideNavItems should use a ul rather than div #10515

Closed
2 tasks done
samrobbins85 opened this issue Jan 25, 2022 · 0 comments · Fixed by #10516
Closed
2 tasks done

[a11y]: HeaderSideNavItems should use a ul rather than div #10515

samrobbins85 opened this issue Jan 25, 2022 · 0 comments · Fixed by #10516
Assignees

Comments

@samrobbins85
Copy link

Package

carbon-components-react

Browser

Chrome

Operating System

MacOS

Package version

7.50.0

React version

16.14.0

Automated testing tool and ruleset

axe devtools

Assistive technology

No response

Description

Using the method described in storybook of <HeaderSideNavItems> with <HeaderMenuItem>s nested inside you get a div (HeaderSideNavItems) containing lis (HeaderMenuItem). Instead HeaderSideNavItems should be a list

WCAG 2.1 Violation

Success Criterion 1.3.1 Info and Relationships

CodeSandbox example

https://codesandbox.io/s/ibm-sidenav-a11y-2-yrwlo?file=/package.json

Steps to reproduce

Narrow the window such that the mobile menu comes up, open this menu and inspect the top section, it contains a div containing lis

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants