Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

fix(select): add custom selected event for select component #667

Merged

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Jul 8, 2021

Related Ticket(s)

'@input' event does not work ('oninput' works, but not in Firefox). #665

Description

Add bx-select-selected custom event that's dispatched when item is selected from select component

Changelog

New

  • bx-select-selected custom event added to select component

@ibmdotcom-bot
Copy link
Contributor

@ibmdotcom-bot
Copy link
Contributor

@ibmdotcom-bot
Copy link
Contributor

@ibmdotcom-bot
Copy link
Contributor

Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jul 8, 2021
@kodiakhq kodiakhq bot merged commit 2a4e7f0 into carbon-design-system:master Jul 8, 2021
@annawen1 annawen1 deleted the fix/select-input-custom-event branch July 8, 2021 19:45
@rkgriff
Copy link

rkgriff commented Jul 28, 2021

@jeffchew hi Jeff, can you let me know how we can get this change in new bundle? The link above for deploy preview created for Carbon Web Components brings up version 1.14.1. Would we just install this version by doing npm install --save [email protected]? Or do we get this update some other way? Thanks.

@jeffchew
Copy link
Member

@rkgriff you can run the following in your project:

npm update carbon-web-components@latest

@rkgriff
Copy link

rkgriff commented Jul 28, 2021

@jeffchew Thanks Jeff. If I run npm update carbon-web-components@latest in my project it says everything is up to date. But, I still see this version listed in my package.json file - "carbon-web-components": "^1.13.3". Doing something wrong? Thanks.

@annawen1
Copy link
Member Author

annawen1 commented Jul 29, 2021

@rkgriff Since you're using the ^ prepended to the version, your project should already be using 1.14.1

^version will update you to all future minor/patch versions, without incrementing the major version (ie. ^1.13.3 will use releases from 1.13.3 to <2.0.0)

You can also go into the package.json file and manually change the version:

"carbon-web-components": "1.15.1"

and then run

npm install

@rkgriff
Copy link

rkgriff commented Jul 29, 2021

@annawen1 Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants