-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pogs subdir tests failing #49
Comments
Woah. Legit failure and seems to be Go 1.7-related: I can repro on linux/amd64 with Go 1.7 but not Go 1.6. Investigating. |
Fix in progress, but here's the issue (and I think it's also present in v1, but haven't confirmed yet): the schema data that is stored in the generated code is packed+zlib compressed. In Go 1.7, the flate reader now returns an error along with the data of the last read. The packed decompressor does not handle this case and drops the tail end of the bytes. I'm rewriting the decompressor to handle this better. |
oh interesting. the release notes mention something about this...
|
I've rewritten the decompressor now. You may want to backport it to go-capnproto v1, as I ended up improving performance by 3x while doing this. |
@zombiezen excellent. |
pogs seems pretty awesome. Very similar to what I ended up doing in practice anyway: I always ended up defining a plain Go struct that mirrored the capnp struct (and thus motivated the github.com/glycerine/bambam mini-project for the reverse direction). So I'd love to see go-capnproto2's pogs in action.
Strangely the tests seem to fail for me, using go1.7 on osx 10.11.6 El Capitan.
Certainly could be user error on my part...I didn't try to troubleshoot much here... please advise.
The text was updated successfully, but these errors were encountered: