fix: wrap values in array if it is object, so it can be spreaded #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelBrucksch
commented
Nov 5, 2024
SamuelBrucksch
changed the title
SamuelBrucksch
changed the title
BobdenOs
reviewed
Nov 5, 2024
BobdenOs
reviewed
Nov 6, 2024
SamuelBrucksch
commented
Nov 8, 2024
SamuelBrucksch
requested review from
danjoa,
johannes-vogel,
stewsk,
patricebender,
sjvans and
David-Kunz
as code owners
BobdenOs
approved these changes
Nov 22, 2024
Merged
johannes-vogel
added a commit
that referenced
this pull request
Nov 25, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.16.0</summary> ## [1.16.0](db-service-v1.15.1...db-service-v1.16.0) (2024-11-25) ### Changed * single column in `search` function is also treated as CQN `list` ([#898](#898)) ([f6593e6](f6593e6)) ### Fixed * foreignKeys aspect on association may not be set ([#903](#903)) ([732a2f3](732a2f3)) * insert on uuid with default value ([#911](#911)) ([545e489](545e489)) * `session_context`, `current_date`, `current_time` and `current_timestamp` are treated as SAP HANA functions and are callable in upper case ([#910](#910)) ([50ebd10](50ebd10)) * wrap values in array if it is object, so it can be spreaded ([#882](#882)) ([11f3e8b](11f3e8b)) </details> <details><summary>hana: 1.5.0</summary> ## [1.5.0](hana-v1.4.1...hana-v1.5.0) (2024-11-25) ### Added * config options for fuzzy search ([#898](#898)) ([f6593e6](f6593e6)) * support current_utctimestamp ([#865](#865)) ([aaf39ad](aaf39ad)) ### Fixed * `current_date`, `current_time`, `current_timestamp` and `current_utctimestamp` are SAP HANA functions and are callable in upper case ([#910](#910)) ([50ebd10](50ebd10)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Johannes Vogel <[email protected]>
This was referenced Jan 28, 2025
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A query with no properties remaining caused a TypeError earlier, as we try to destructure an object:
So if it is wrapped as array, the TypeError does not exist anymore.