fix(mtx): sidecar scenario due to usage of wrong credentials #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaldmann
requested review from
danjoa,
johannes-vogel,
stewsk,
BobdenOs,
patricebender and
sjvans
as code owners
swaldmann
changed the title
|
@swaldmann Do you know what was different in old db impl? To me it seems pretty much the same logic for mt detection. |
swaldmann
changed the title
BobdenOs
approved these changes
Jul 8, 2024
|
Discussed in DB layer sync -- we'll take this impl as it works for older versions of |
patricebender
approved these changes
Jul 8, 2024
johannes-vogel
changed the title
Merged
johannes-vogel
added a commit
that referenced
this pull request
Jul 8, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.11.0</summary> ## [1.11.0](db-service-v1.10.3...db-service-v1.11.0) (2024-07-08) ### Added * **search:** enable deep search with path expressions ([#590](#590)) ([e9e9461](e9e9461)) ### Changed * `search` interprets only first search term instead of raising an error ([#707](#707)) ([0b9108c](0b9108c)) ### Fixed * optimize foreign key access for expand with aggregations ([#734](#734)) ([77b7978](77b7978)) </details> <details><summary>hana: 1.1.0</summary> ## [1.1.0](hana-v1.0.1...hana-v1.1.0) (2024-07-08) ### Added * Enable native HANA fuzzy search for `search` function queries ([#707](#707)) ([0b9108c](0b9108c)) ### Fixed * **mtx:** sidecar scenario due to usage of wrong credentials ([#732](#732)) ([0b5c91f](0b5c91f)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Johannes Vogel <[email protected]>
This was referenced Jan 28, 2025
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a out of memory in
@cap-js/hanathat doesn't occur with@sap/cds-hana:To get heap snapshots run this instead of plain
cds run:Turns out the memory is full of type errors from
hdb:From the error I could tell it tried to open the
hdbconnection with Service Manger credentials instead of the actual credentials fetched from it.The problem is that in a sidecar scenario we don't explicitly set
cds.requires.multitenancy(might change, see also internally cap/cds-mtxs/pull/1006), so@cap-js/hanatakes a wrong turn.I also found out the
createfunction here is called extremely often in succession in the error case, which explains why the memory is filled up so quickly.This PR fixes the issue for our sidecar setup and older MTX versions (if we also decide to go with cap/cds-mtxs/pull/1006) but we should still investigate in a follow-up how the behavior can be improved so the
createisn't called so often without debouncing and filling up the memory in the error case.