feat: Improved connection pool for HANAService #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobdenOs
requested review from
danjoa,
johannes-vogel and
stewsk
as code owners
hana/lib/drivers/hana-client.js
Outdated
| creds.pooling = true | ||
| Object.assign(creds, { | ||
| // Enables the @sap/hana-client native connection pool implementation | ||
| pooling: true, |
There was a problem hiding this comment.
creds.pooling is set to true twice, reason?
hana/lib/HANAService.js
Outdated
| const driver = drivers[this.options.driver || this.options.credentials.driver]?.driver || drivers.default.driver | ||
| const dbc = new driver(this.options.credentials) | ||
| options: driver.pool // Ignore generic-pool when native pool is available | ||
| ? { min: 0, max: 1000 } |
There was a problem hiding this comment.
please use the default values we've dicussed → documented in our internal bli
hana/lib/HANAService.js
Outdated
| }, | ||
| create: async (tenant) => { | ||
| const creds = isMultitenant | ||
| ? await require('@sap/cds-mtxs/lib').xt.serviceManager.get(tenant, { disableCache: this.disableCache || false }) |
There was a problem hiding this comment.
when is this.disableCache set?
I think we need to enhance the error listener here.
Also if the credentials are wrong in mt scenario, we should not crash but stop fetching the credentials from service manager after e. g. 3 times.
hana/lib/drivers/hana-client.js
Outdated
| maxPoolSize: 100, // TODO: align to options.pool configurations | ||
|
|
||
| // If communicationTimeout is not set queries will hang for over 10 minutes | ||
| communicationTimeout: 5000, |
There was a problem hiding this comment.
are those properties "mappable" 1-1 to generic-pool settings?
…ds-dbs into hana-pool-configuration
johannes-vogel
approved these changes
Dec 6, 2023
Merged
Merged
This was referenced Jan 28, 2025
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses@sap/hana-clientnative connection pool implementationnode-hdb@sap/hana-clientcredential mappings to the old HANA Service