Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove line length checks from CI linters #207

Closed
lengau opened this issue Apr 24, 2024 · 2 comments · Fixed by #221
Closed

Remove line length checks from CI linters #207

lengau opened this issue Apr 24, 2024 · 2 comments · Fixed by #221
Assignees
Labels
Enhancement New feature or request Triaged

Comments

@lengau
Copy link
Contributor

lengau commented Apr 24, 2024

Discussed in an in-person sync:

We still want to keep line endings to a sane length, but we can do that through editorconfig. However, sometimes keeping with the letter of that defeats the spirit of the line length improving readability. See: #203

Actions to take from this:

  • Enable max_line_length = 80 for markdown and rst files in editorconfig
  • Keep (and enable where available but not used) max line lengths in any auto-formatters
  • Determine at engineering sprint what our appropriate linter line length is.
@sergiusens
Copy link
Collaborator

sergiusens commented May 17, 2024

Set line length limit for rst to 88
For the badges in readme, use txt inclusion (see if GH would support it)

@lengau lengau self-assigned this May 17, 2024
@lengau lengau added Enhancement New feature or request Triaged labels Jun 6, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3002.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants