From 020c329e11ea502949df848966d7d3320aee2235 Mon Sep 17 00:00:00 2001 From: James Falcon Date: Mon, 5 Aug 2024 23:07:39 -0500 Subject: [PATCH] chore: Stop running mypy on tests Often times we need to test error conditions or invalid input. That necessitates doing things that mypy considers unsound. While mypy can also provide some benefit to testing, the cost of silencing errors isn't worth the benefit. --- pyproject.toml | 114 ------------------------------------------------- tox.ini | 2 +- 2 files changed, 1 insertion(+), 115 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index d5578c1379b..b74722e0012 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -119,120 +119,6 @@ module = [ "cloudinit.temp_utils", "cloudinit.templater", "cloudinit.user_data", - "tests.integration_tests.instances", - "tests.unittests.analyze.test_show", - "tests.unittests.cmd.devel.test_hotplug_hook", - "tests.unittests.cmd.devel.test_render", - "tests.unittests.cmd.test_clean", - "tests.unittests.cmd.test_query", - "tests.unittests.cmd.test_status", - "tests.unittests.config.test_apt_configure_sources_list_v1", - "tests.unittests.config.test_apt_configure_sources_list_v3", - "tests.unittests.config.test_apt_source_v1", - "tests.unittests.config.test_apt_source_v3", - "tests.unittests.config.test_cc_ansible", - "tests.unittests.config.test_cc_apk_configure", - "tests.unittests.config.test_cc_apt_pipelining", - "tests.unittests.config.test_cc_bootcmd", - "tests.unittests.config.test_cc_ca_certs", - "tests.unittests.config.test_cc_chef", - "tests.unittests.config.test_cc_disable_ec2_metadata", - "tests.unittests.config.test_cc_final_message", - "tests.unittests.config.test_cc_growpart", - "tests.unittests.config.test_cc_grub_dpkg", - "tests.unittests.config.test_cc_install_hotplug", - "tests.unittests.config.test_cc_keys_to_console", - "tests.unittests.config.test_cc_landscape", - "tests.unittests.config.test_cc_locale", - "tests.unittests.config.test_cc_mcollective", - "tests.unittests.config.test_cc_mounts", - "tests.unittests.config.test_cc_ntp", - "tests.unittests.config.test_cc_phone_home", - "tests.unittests.config.test_cc_power_state_change", - "tests.unittests.config.test_cc_puppet", - "tests.unittests.config.test_cc_resizefs", - "tests.unittests.config.test_cc_resolv_conf", - "tests.unittests.config.test_cc_rh_subscription", - "tests.unittests.config.test_cc_rsyslog", - "tests.unittests.config.test_cc_runcmd", - "tests.unittests.config.test_cc_set_hostname", - "tests.unittests.config.test_cc_snap", - "tests.unittests.config.test_cc_ssh", - "tests.unittests.config.test_cc_timezone", - "tests.unittests.config.test_cc_ubuntu_autoinstall", - "tests.unittests.config.test_cc_ubuntu_drivers", - "tests.unittests.config.test_cc_ubuntu_pro", - "tests.unittests.config.test_cc_update_etc_hosts", - "tests.unittests.config.test_cc_users_groups", - "tests.unittests.config.test_cc_wireguard", - "tests.unittests.config.test_cc_yum_add_repo", - "tests.unittests.config.test_cc_zypper_add_repo", - "tests.unittests.config.test_modules", - "tests.unittests.config.test_schema", - "tests.unittests.conftest", - "tests.unittests.distros.test_alpine", - "tests.unittests.distros.test_hosts", - "tests.unittests.distros.test_ifconfig", - "tests.unittests.distros.test_netbsd", - "tests.unittests.distros.test_netconfig", - "tests.unittests.distros.test_opensuse", - "tests.unittests.distros.test_user_data_normalize", - "tests.unittests.helpers", - "tests.unittests.net.test_dhcp", - "tests.unittests.net.test_init", - "tests.unittests.net.test_network_state", - "tests.unittests.net.test_networkd", - "tests.unittests.runs.test_merge_run", - "tests.unittests.runs.test_simple_run", - "tests.unittests.sources.azure.test_errors", - "tests.unittests.sources.azure.test_imds", - "tests.unittests.sources.helpers.test_openstack", - "tests.unittests.sources.test_aliyun", - "tests.unittests.sources.test_altcloud", - "tests.unittests.sources.test_azure", - "tests.unittests.sources.test_azure_helper", - "tests.unittests.sources.test_cloudsigma", - "tests.unittests.sources.test_common", - "tests.unittests.sources.test_configdrive", - "tests.unittests.sources.test_digitalocean", - "tests.unittests.sources.test_ec2", - "tests.unittests.sources.test_exoscale", - "tests.unittests.sources.test_gce", - "tests.unittests.sources.test_init", - "tests.unittests.sources.test_lxd", - "tests.unittests.sources.test_maas", - "tests.unittests.sources.test_nocloud", - "tests.unittests.sources.test_opennebula", - "tests.unittests.sources.test_openstack", - "tests.unittests.sources.test_oracle", - "tests.unittests.sources.test_ovf", - "tests.unittests.sources.test_rbx", - "tests.unittests.sources.test_scaleway", - "tests.unittests.sources.test_smartos", - "tests.unittests.sources.test_upcloud", - "tests.unittests.sources.test_vultr", - "tests.unittests.sources.test_wsl", - "tests.unittests.sources.vmware.test_vmware_config_file", - "tests.unittests.test__init__", - "tests.unittests.test_apport", - "tests.unittests.test_builtin_handlers", - "tests.unittests.test_cli", - "tests.unittests.test_conftest", - "tests.unittests.test_data", - "tests.unittests.test_ds_identify", - "tests.unittests.test_helpers", - "tests.unittests.test_log", - "tests.unittests.test_merging", - "tests.unittests.test_net", - "tests.unittests.test_net_activators", - "tests.unittests.test_ssh_util", - "tests.unittests.test_stages", - "tests.unittests.test_subp", - "tests.unittests.test_templating", - "tests.unittests.test_upgrade", - "tests.unittests.test_url_helper", - "tests.unittests.test_util", - "tests.unittests.util", # tools/* "netplan_schema_check", diff --git a/tox.ini b/tox.ini index d6982cbe382..3132d9831a8 100644 --- a/tox.ini +++ b/tox.ini @@ -82,7 +82,7 @@ deps = types-requests=={[format_deps]types-requests} types-setuptools=={[format_deps]types-setuptools} typing-extensions=={[format_deps]typing-extensions} -commands = {envpython} -m mypy {posargs:cloudinit/ tests/ tools/} +commands = {envpython} -m mypy {posargs:cloudinit/ tools/} [testenv:check_format] deps =