Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused test connection pod #3001

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

hisImminence
Copy link
Contributor

@hisImminence hisImminence commented Feb 25, 2025

Which problem does the PR fix?

Removes connection pods from the each version of the Helm Charts. They were used in the past to check the health of the applications but are not needed anymore as we only should rely on the health/readiness checks moving forward.

hint for review: Follow the single commits to see the changes separated per camunda-chart

related to: #2984 (comment)

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@hisImminence hisImminence requested a review from a team February 25, 2025 20:36
@hisImminence hisImminence self-assigned this Feb 25, 2025
@github-actions github-actions bot added version/8.2 Camunda applications/cycle version version/8.3 Camunda applications/cycle version component/zeebe version/8.4 Camunda applications/cycle version version/8.5 Camunda applications/cycle version version/8.6 Camunda applications/cycle version component/web-modeler component/identity component/operate component/optimize component/tasklist version/alpha Camunda applications/cycle version (this is a pointer to alpha) labels Feb 25, 2025
@hisImminence hisImminence changed the title Remove unused test connection pod fix: remove unused test connection pod Feb 25, 2025
@aabouzaid aabouzaid requested review from aabouzaid and removed request for a team February 27, 2025 10:51
@aabouzaid aabouzaid force-pushed the remove-unused-test-connectino-pod branch 10 times, most recently from f48e7e7 to e858942 Compare February 27, 2025 11:18
@aabouzaid aabouzaid force-pushed the remove-unused-test-connectino-pod branch 7 times, most recently from e1bdcde to f16ce6d Compare February 27, 2025 11:40
also detect deleted files as changed
@aabouzaid aabouzaid force-pushed the remove-unused-test-connectino-pod branch from f16ce6d to bb62fb4 Compare February 27, 2025 11:41
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hisImminence I've made a small change to detect deleted files.

Based on tj-actions/changed-files docs, the output all_changed_files doesn't detect the deleted files, only edited ones.

Swtiching to all_modified_files fixed the issue.

@hisImminence
Copy link
Contributor Author

@hisImminence I've made a small change to detect deleted files.

Based on tj-actions/changed-files docs, the output all_changed_files doesn't detect the deleted files, only edited ones.

Swtiching to all_modified_files fixed the issue.

Nice! This should then also prevent bugs like https://camunda.slack.com/archives/C06BN4SRB6C/p1740481289713889?thread_ts=1740473152.702229&cid=C06BN4SRB6C moving forward!

Thanks @aabouzaid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci component/identity component/operate component/optimize component/tasklist component/web-modeler component/zeebe tool/github-actions version/alpha Camunda applications/cycle version (this is a pointer to alpha) version/8.2 Camunda applications/cycle version version/8.3 Camunda applications/cycle version version/8.4 Camunda applications/cycle version version/8.5 Camunda applications/cycle version version/8.6 Camunda applications/cycle version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants