-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unused test connection pod #3001
Conversation
f48e7e7
to
e858942
Compare
e1bdcde
to
f16ce6d
Compare
also detect deleted files as changed
f16ce6d
to
bb62fb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hisImminence I've made a small change to detect deleted files.
Based on tj-actions/changed-files docs, the output all_changed_files doesn't detect the deleted files, only edited ones.
Swtiching to all_modified_files fixed the issue.
Nice! This should then also prevent bugs like https://camunda.slack.com/archives/C06BN4SRB6C/p1740481289713889?thread_ts=1740473152.702229&cid=C06BN4SRB6C moving forward! Thanks @aabouzaid! |
Which problem does the PR fix?
Removes connection pods from the each version of the Helm Charts. They were used in the past to check the health of the applications but are not needed anymore as we only should rely on the health/readiness checks moving forward.
hint for review: Follow the single commits to see the changes separated per camunda-chart
related to: #2984 (comment)
What's in this PR?
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only
.After opening the PR: