From d4d4fc89b980fb8ccdce7842be37f46ea9ea9731 Mon Sep 17 00:00:00 2001
From: Philipp <philippfromme@outlook.com>
Date: Sun, 26 Mar 2023 14:06:34 +0200
Subject: [PATCH] fix: disallow error references without error code

Related to https://github.com/camunda/camunda-modeler/issues/3362
---
 rules/error-reference.js                   |  3 +--
 test/camunda-cloud/error-reference.spec.js | 23 ++++------------------
 2 files changed, 5 insertions(+), 21 deletions(-)

diff --git a/rules/error-reference.js b/rules/error-reference.js
index bd7625f5..06550b50 100644
--- a/rules/error-reference.js
+++ b/rules/error-reference.js
@@ -47,8 +47,7 @@ module.exports = skipInNonExecutableProcess(function({ version }) {
 
     errors = hasProperties(errorRef, {
       errorCode: {
-        required: true,
-        allowedVersion: '8.2'
+        required: true
       }
     }, node);
 
diff --git a/test/camunda-cloud/error-reference.spec.js b/test/camunda-cloud/error-reference.spec.js
index 9a38be2c..3474cd6d 100644
--- a/test/camunda-cloud/error-reference.spec.js
+++ b/test/camunda-cloud/error-reference.spec.js
@@ -52,19 +52,6 @@ const valid = [
       </bpmn:boundaryEvent>
     `))
   },
-  {
-    name: 'error boundary event (no error code) (Camunda 8.2)',
-    config: { version: '8.2' },
-    moddleElement: createModdle(createDefinitions(`
-      <bpmn:process id="Process_1">
-        <bpmn:task id="Task_1" />
-        <bpmn:boundaryEvent id="BoundaryEvent_1" attachedToRef="Task_1">
-          <bpmn:errorEventDefinition id="ErrorEventDefinition_1" errorRef="Error_1" />
-        </bpmn:boundaryEvent>
-      </bpmn:process>
-      <bpmn:error id="Error_1" />
-    `))
-  },
   {
     name: 'error end event (no error reference) (non-executable process)',
     config: { version: '8.2' },
@@ -117,7 +104,7 @@ const invalid = [
     `)),
     report: {
       id: 'EndEvent_1',
-      message: 'Element of type <bpmn:Error> without property <errorCode> only allowed by Camunda Platform 8.2 or newer',
+      message: 'Element of type <bpmn:Error> must have property <errorCode>',
       path: [
         'rootElements',
         1,
@@ -127,8 +114,7 @@ const invalid = [
         type: ERROR_TYPES.PROPERTY_REQUIRED,
         node: 'Error_1',
         parentNode: 'EndEvent_1',
-        requiredProperty: 'errorCode',
-        allowedVersion: '8.2'
+        requiredProperty: 'errorCode'
       }
     }
   },
@@ -172,7 +158,7 @@ const invalid = [
     `)),
     report: {
       id: 'BoundaryEvent_1',
-      message: 'Element of type <bpmn:Error> without property <errorCode> only allowed by Camunda Platform 8.2 or newer',
+      message: 'Element of type <bpmn:Error> must have property <errorCode>',
       path: [
         'rootElements',
         1,
@@ -182,8 +168,7 @@ const invalid = [
         type: ERROR_TYPES.PROPERTY_REQUIRED,
         node: 'Error_1',
         parentNode: 'BoundaryEvent_1',
-        requiredProperty: 'errorCode',
-        allowedVersion: '8.2'
+        requiredProperty: 'errorCode'
       }
     }
   },