Update Zeebe to 8.2.0-rc1 #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Engine method was changed in Zeebe. The EngineConfiguration parameter was added, this also needs to be removed here. The createEngineProcessors method was changed in Zeebe.One of the parameters was removed, this also needs to be removed here. The createEngineProcessors method was changed in Zeebe.The JobStreamer parameter was added, this also needs to be added here.
|
Hey, @saig0 @Zelldon, The |
|
And |
|
@skayliu thank you for your contribution. 🎉 I will have a look at your changes soon. 👀 |
saig0
requested changes
Mar 29, 2023
Comment on lines
1119
to
1179
| // given | ||
| zeebeClient = ZeebeClient.newClientBuilder().usePlaintext().build() | ||
|
|
||
| zeebeClient.newDeployResourceCommand() | ||
| .addProcessModel( | ||
| Bpmn.createExecutableProcess("process") | ||
| .startEvent() | ||
| .signal("top-level-start-signal") | ||
| .endEvent() | ||
| .done(), "process.bpmn" | ||
| ) | ||
| .send() | ||
| .join() | ||
|
|
||
| // when | ||
| zeebeClient | ||
| .newBroadcastSignalCommand() | ||
| .signalName("top-level-start-signal") | ||
| .variables(mapOf("signal" to "broadCasted")) | ||
| .send() | ||
| .join() | ||
|
|
||
| // then | ||
| val signalSubscriptionRecord = zeebeEngine | ||
| .signalSubscriptionRecords() | ||
| .withIntent(SignalSubscriptionIntent.CREATED) | ||
| .firstOrNull() | ||
|
|
||
| assertThat(signalSubscriptionRecord) | ||
| .describedAs("When deploy a process with top-level signal start event a signal subscription record is created") | ||
| .isNotNull | ||
| if (signalSubscriptionRecord != null) { | ||
| assertThat(signalSubscriptionRecord.value.signalName).isEqualTo("top-level-start-signal") | ||
| } | ||
|
|
||
| val signalRecord = zeebeEngine | ||
| .signalRecords() | ||
| .withIntent(SignalIntent.BROADCASTED) | ||
| .firstOrNull() | ||
|
|
||
| assertThat(signalRecord) | ||
| .describedAs("The Signal is broadcasted well") | ||
| .isNotNull | ||
|
|
||
| if (signalRecord != null) { | ||
| assertThat(signalRecord.value.signalName).isEqualTo("top-level-start-signal") | ||
| assertThat(signalRecord.value.variables) | ||
| .describedAs("The signal broadcast command can has variables") | ||
| .containsEntry("signal", "broadCasted") | ||
| } | ||
|
|
||
| val processInstance = zeebeEngine | ||
| .processInstanceRecords() | ||
| .withIntent(ProcessInstanceIntent.ELEMENT_COMPLETED) | ||
| .withElementType(BpmnElementType.PROCESS) | ||
| .firstOrNull() | ||
|
|
||
| assertThat(processInstance) | ||
| .describedAs("The top-level signal start event can be triggered by signal broadcast command") | ||
| .isNotNull | ||
|
|
There was a problem hiding this comment.
❌ This test case can fail because of the async nature of the exporter.
If we verify records on the stream, we should wrap the verification inside a await.untilAsserted { ... } block. This is part of Awaitility to deal with async code.
If I apply the modification, the test case works fine.
The verifications of the signal records could be removed because this is part of Zeebe's workflow engine itself. To verify the signal broadcast, it is enough to verify that the process instance is created/completed.
// given
zeebeClient = ZeebeClient.newClientBuilder().usePlaintext().build()
zeebeClient.newDeployResourceCommand()
.addProcessModel(
Bpmn.createExecutableProcess("signal-process")
.startEvent()
.signal("top-level-start-signal")
.endEvent()
.done(), "process.bpmn"
)
.send()
.join()
// when
zeebeClient
.newBroadcastSignalCommand()
.signalName("top-level-start-signal")
.variables(mapOf("signal" to "broadCasted"))
.send()
.join()
// then
await.untilAsserted {
val processInstance = zeebeEngine
.processInstanceRecords()
.withBpmnProcessId("signal-process")
.withIntent(ProcessInstanceIntent.ELEMENT_COMPLETED)
.withElementType(BpmnElementType.PROCESS)
.firstOrNull()
assertThat(processInstance)
.describedAs("The top-level signal start event can be triggered by signal broadcast command")
.isNotNull
}With the latest Zeebe version, the startAtKey parameter is invoked with null. So, the method should be able to handle null.
|
@saig0, It's all done, please review again, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
8.2.0-alpha5to8.2.0-rc1