feat: Update Zeebe to 8.2.0-alpha4 #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log4j version is not compatible with slf4j 2.x. As a result, the engine produces no logs. Fixing the issue by downgrading to slf4j 1.x.
Closed
ChrisKujawa
reviewed
Feb 21, 2023
| listener: LogStorage.AppendListener | ||
| ) { | ||
| try { | ||
| val entry = Entry(blockBuffer) | ||
| val copy: DirectBuffer = BufferUtil.createCopy(bufferWriter) |
There was a problem hiding this comment.
@saig0 why do you think this was necessary now?
There was a problem hiding this comment.
I kept the original structure of the in-memory log storage. Since the API changed, I needed to extract the content of the BufferWriter to fill the entry.
But maybe, there is another way. I'm open to your ideas. 😄
ChrisKujawa
reviewed
Feb 21, 2023
| @@ -60,7 +60,7 @@ | |||
| <assertj.version>3.24.2</assertj.version> | |||
| <awaitility.version>4.2.0</awaitility.version> | |||
| <log4j.version>2.19.0</log4j.version> | |||
| <slf4j-api.version>2.0.4</slf4j-api.version> | |||
| <slf4j-api.version>1.7.36</slf4j-api.version> | |||
There was a problem hiding this comment.
🤣 Yes. Log4j is not compatible yet. As a result, there were no logs printed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to the latest Zeebe alpha version
8.2.0-alpha4.