-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be able to specify the build command #5
Comments
Thanks for opening this issue @zambrovski! This isn't something I can tackle until at least mid Q3, but if the community would like to see it happen faster, people are more than welcome to submit a pull request! :) |
@zambrovski Following up on this--Would a solution for this then potentially be:
If so, I can make that PR introducing that proposed change. If there's another solution here, I'm more than happy to look into that as well. :) |
Just an update here @zambrovski -- We've got a new PR, #13 open which I think would be able to allow you to then run |
Thank you,
Will have a look on it…
|
Perfectly fine with that solution for tuning the build command. |
The community action maven release simply executes
mvn package
to produce the Maven artifact. In most cases this is ok for beginners, (as a part of the action), but there might be exceptions.Here are some ideas about it:
clean
in order not to depend on previous build. This gets fatal if you for example generate sources and tweak it, easily resulting in having classes multiple times on the classpath.-T4
which accelerates the build. On my experience github actions run faster with at least-T2
or event-T4
Solution idea:
Introduce a variable inside the build action holding the build command, which might be overwritten by the developer, defaulting to
mvn clean package ${SKIP_TESTS}
.The text was updated successfully, but these errors were encountered: