Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected version after alpha release #2

Closed
saig0 opened this issue Apr 21, 2021 · 4 comments
Closed

Unexpected version after alpha release #2

saig0 opened this issue Apr 21, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@saig0
Copy link

saig0 commented Apr 21, 2021

I want to build an alpha release of my project (e.g. 2.0.0-alpha1). It works in general ✔️ but it sets the version for the next release (i.e. prepare for next development iteration) to an unexpected value.

Before:

<version>2.0.0-alpha1</version>

After:

<version>2.0.0-alpha2-SNAPSHOT</version>

Expected:

<version>2.0.0-SNAPSHOT</version>

See camunda-community-hub/zeeqs@b2472c3

@saig0 saig0 added the bug Something isn't working label Apr 21, 2021
@celanthe celanthe self-assigned this May 4, 2021
@celanthe
Copy link
Contributor

celanthe commented May 4, 2021

Hi @saig0! Thank you for raising this issue. I had a look at https://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html and I was wondering if there might be something there that would resolve this?

There is also https://github.com/camunda-community-hub/maven-template which may be able to help as well. If neither of these has a solution, I can dig further into it and escalate to Infra if necessary!

@Langleu
Copy link
Contributor

Langleu commented May 5, 2021

@saig0 the value is actually the expected value given by Maven, see given documentation.
Maven's default is to define the next development version as x.y.(z+1)-SNAPSHOT.

Due to KubeCon I won't find any time this week to have a look.


Relabeled it to enhancement since it's a feature request.
I'll have a look next week whether updating the maven release plugin will change anything about loading release.properties since for now, they don't seem to have an effect and are just deleted. If updating doesn't do anything then we can still resort to parsing the file since it will be deleted at the end of the release by maven.

@Langleu Langleu added enhancement New feature or request and removed bug Something isn't working labels May 5, 2021
@celanthe celanthe added the help wanted Extra attention is needed label Jun 30, 2021
@celanthe
Copy link
Contributor

celanthe commented Jul 8, 2021

Hi @saig0! Just wanted to follow back up on this--We have recently released v1.0.4 of this extension, which merged in #14...Would this perhaps solve your issue? There was also #13 that may allow you to set different options for Snapshots.

If neither of these new updates solve this, not to worry, I'll leave this issue open until we can resolve it! :)

@berndruecker
Copy link
Contributor

Howdy @saig0 - I close this for now - please let me know if there is something still open - then we can have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants