Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental: pressable component hover style #65

Closed
wants to merge 0 commits into from

Conversation

gokul1099
Copy link

@gokul1099 gokul1099 commented Dec 23, 2023

Summary:

This PR is an experimental fix for #12. In this PR I have added method to apply the borderRadius style which is applied to View to hoverStyle. Currently I have added support for borderRadius style. But for other cases like borderTopEndRadius, borderTopStartRadius will not work.

Changelog:

[VISIONOS] - added method to apply borderRadius to hoverStyle

Test Plan:

@okwasniewski
Copy link
Member

Hey, thanks for opening the PR can you rebase on top of main and resolve conflicts? I will check it out after the rebase

@gokul1099 gokul1099 force-pushed the pressable_hoverstyle_fix branch from 4091760 to 63a8c84 Compare January 2, 2024 16:35
@gokul1099 gokul1099 closed this Jan 2, 2024
@gokul1099 gokul1099 force-pushed the pressable_hoverstyle_fix branch from 63a8c84 to e6df7ca Compare January 2, 2024 18:42
@gokul1099
Copy link
Author

@okwasniewski faced some issue while rebasing and this pull request closed automatcally when try to reset the branch. raised a separate pull request kindly check #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants